Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[jsdoc] failing typescript builds - wrong type

Browse Source 
`HTMLSectionElement` is not part of the DOM, so the generated typescript definitions contain a non-existing type.

HTML Section elements have to be handled as simple `HTMLElements`.

fixing punctuation and lint problems

[jsdoc] failing typescript builds - wrong type
This commit is contained in:
Bernát Gyovai 2022-07-07 15:06:58 +02:00 committed by Bernat Gyovai (Zardify)
parent 7f160d49f9
commit 3d62f09fbd
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/display/annotation_layer.js
View File

@ -190,7 +190,7 @@ class AnnotationElement {
* @private * @private
* @param {boolean} ignoreBorder * @param {boolean} ignoreBorder
* @memberof AnnotationElement * @memberof AnnotationElement
* @returns {HTMLSectionElement} * @returns {HTMLElement} A section element.
*/ */
_createContainer(ignoreBorder = false) { _createContainer(ignoreBorder = false) {
const data = this.data, const data = this.data,
@ -410,7 +410,7 @@ class AnnotationElement {
* @private * @private
* @param {boolean} ignoreBorder * @param {boolean} ignoreBorder
* @memberof AnnotationElement * @memberof AnnotationElement
* @returns {Array<HTMLSectionElement>} * @returns {Array<HTMLElement>} An array of section elements.
*/ */
_createQuadrilaterals(ignoreBorder = false) { _createQuadrilaterals(ignoreBorder = false) {
if (!this.data.quadPoints) { if (!this.data.quadPoints) {
@ -480,7 +480,7 @@ class AnnotationElement {
* @private * @private
* @param {string} className * @param {string} className
* @memberof AnnotationElement * @memberof AnnotationElement
* @returns {Array<HTMLSectionElement>} * @returns {Array<HTMLElement>} An array of section elements.
*/ */
_renderQuadrilaterals(className) { _renderQuadrilaterals(className) {
if ( if (
@ -501,7 +501,8 @@ class AnnotationElement {
* *
* @public * @public
* @memberof AnnotationElement * @memberof AnnotationElement
* @returns {HTMLSectionElement|Array<HTMLSectionElement>} * @returns {HTMLElement|Array<HTMLElement>} A section element or
* an array of section elements.
*/ */
render() { render() {
unreachable("Abstract method `AnnotationElement.render` called"); unreachable("Abstract method `AnnotationElement.render` called");