From 3c6b3b55c763fbbb45d56404a055ff32f52c3c37 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Tue, 13 Sep 2022 14:12:36 +0200 Subject: [PATCH] Move the `errorWrapper` definition in the `getViewerConfiguration` function Similar to how we handle e.g. the "Open File"-buttons in non-GENERIC builds, we can handle the `errorWrapper` definition in the same way. --- web/viewer.js | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/web/viewer.js b/web/viewer.js index 93775403c..ccd1ffa20 100644 --- a/web/viewer.js +++ b/web/viewer.js @@ -69,18 +69,6 @@ if (typeof PDFJSDev !== "undefined" && PDFJSDev.test("CHROME || GENERIC")) { } function getViewerConfiguration() { - let errorWrapper = null; - if (typeof PDFJSDev === "undefined" || !PDFJSDev.test("MOZCENTRAL")) { - errorWrapper = { - container: document.getElementById("errorWrapper"), - errorMessage: document.getElementById("errorMessage"), - closeButton: document.getElementById("errorClose"), - errorMoreInfo: document.getElementById("errorMoreInfo"), - moreInfoButton: document.getElementById("errorShowMore"), - lessInfoButton: document.getElementById("errorShowLess"), - }; - } - return { appContainer: document.body, mainContainer: document.getElementById("viewerContainer"), @@ -207,7 +195,17 @@ function getViewerConfiguration() { editorInkThickness: document.getElementById("editorInkThickness"), editorInkOpacity: document.getElementById("editorInkOpacity"), }, - errorWrapper, + errorWrapper: + typeof PDFJSDev === "undefined" || !PDFJSDev.test("MOZCENTRAL") + ? { + container: document.getElementById("errorWrapper"), + errorMessage: document.getElementById("errorMessage"), + closeButton: document.getElementById("errorClose"), + errorMoreInfo: document.getElementById("errorMoreInfo"), + moreInfoButton: document.getElementById("errorShowMore"), + lessInfoButton: document.getElementById("errorShowLess"), + } + : null, printContainer: document.getElementById("printContainer"), openFileInput: typeof PDFJSDev === "undefined" || PDFJSDev.test("GENERIC")