Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #9124 from Snuffleupagus/scrollThumbnailIntoView-multi-cols

Browse Source 
Fix incorrect behaviour in `PDFThumbnailViewer.scrollThumbnailIntoView` for multiple columns of thumbnails
This commit is contained in:
Tim van der Meij 2017-11-12 11:41:44 +01:00 committed by GitHub
commit 36b83c14f9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
web/pdf_thumbnail_viewer.js
View File

@ -84,7 +84,20 @@ class PDFThumbnailViewer {
let first = visibleThumbs.first.id; let first = visibleThumbs.first.id;
// Account for only one thumbnail being visible. // Account for only one thumbnail being visible.
let last = (numVisibleThumbs > 1 ? visibleThumbs.last.id : first); let last = (numVisibleThumbs > 1 ? visibleThumbs.last.id : first);
let shouldScroll = false;
if (page <= first || page >= last) { if (page <= first || page >= last) {
shouldScroll = true;
} else {
visibleThumbs.views.some(function(view) {
if (view.id !== page) {
return false;
}
shouldScroll = view.percent < 100;
return true;
});
}
if (shouldScroll) {
scrollIntoView(thumbnail, { top: THUMBNAIL_SCROLL_MARGIN, }); scrollIntoView(thumbnail, { top: THUMBNAIL_SCROLL_MARGIN, });
} }
} }