Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove the disableFullscreen hack for embedded IE 11 (issue 9585)

Browse Source 
It appears that Microsoft silently fixed the problem that required disabling of fullscreen mode, in e.g. `iframe`s, in IE 11; please see issue 4711 and PR 5525 for historical context.

Unfortunately my Google-fu isn't strong enough to find any *official* information regarding the fixing of the browser bug in IE. However testing of the default viewer in IE 11, with this patch applied, it now appears that Presentation Mode is working correctly even in an `iframe` in IE 11.
Further anecdotal evidence that the bug is in fact fixed, is for example that jQuery previously contained a work-around for the IE bug. However, that's removed over two years ago now; see ff1a0822f7 and the issues referenced there.

Given that the default viewer isn't intended to be used as-is anyway (in custom deployments), it didn't seem necessary to keep the `disableFullscreen` option around since it was *only* ever added for compatibility purposes.

Fixes 9585.
This commit is contained in:
Jonas Jenwald 2018-06-14 11:51:25 +02:00
parent b590519ea2
commit 349b7d5e9c
3 changed files with 0 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
web/app.js
View File

@ -553,10 +553,6 @@ let PDFViewerApplication = {
support = false; support = false;
} }
} }
if (support && AppOptions.get('disableFullscreen') === true) {
support = false;
}
return shadow(this, 'supportsFullscreen', support); return shadow(this, 'supportsFullscreen', support);
}, },

5
web/app_options.js
View File

@ -43,11 +43,6 @@ const defaultOptions = {
value: '', value: '',
kind: OptionKind.VIEWER, kind: OptionKind.VIEWER,
}, },
disableFullscreen: {
/** @type {boolean} */
value: viewerCompatibilityParams.disableFullscreen || false,
kind: OptionKind.VIEWER,
},
disableHistory: { disableHistory: {
/** @type {boolean} */ /** @type {boolean} */
value: false, value: false,

9
web/viewer_compatibility.js
View File

@ -18,17 +18,8 @@ if (typeof PDFJSDev === 'undefined' || PDFJSDev.test('GENERIC')) {
const userAgent = const userAgent =
(typeof navigator !== 'undefined' && navigator.userAgent) || ''; (typeof navigator !== 'undefined' && navigator.userAgent) || '';
const isAndroid = /Android/.test(userAgent); const isAndroid = /Android/.test(userAgent);
const isIE = /Trident/.test(userAgent);
const isIOS = /\b(iPad|iPhone|iPod)(?=;)/.test(userAgent); const isIOS = /\b(iPad|iPhone|iPod)(?=;)/.test(userAgent);
// Disable fullscreen support for certain problematic configurations.
// Support: IE11+ (when embedded).
(function checkFullscreenSupport() {
if (isIE && window.parent !== window) {
compatibilityParams.disableFullscreen = true;
}
})();
// Limit canvas size to 5 mega-pixels on mobile. // Limit canvas size to 5 mega-pixels on mobile.
// Support: Android, iOS // Support: Android, iOS
(function checkCanvasSizeLimitation() { (function checkCanvasSizeLimitation() {