Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Convert the DOMCMapReaderFactory to an ES6 class

Browse Source 
Given that we only create *one* instance of this class per `getDocument` call, this shouldn't matter performance wise.
This commit is contained in:
Jonas Jenwald 2017-05-05 17:55:02 +02:00
parent 15425d5b9b
commit 32baa6af7a
2 changed files with 47 additions and 53 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/display/dom_utils.js
View File

@ -52,22 +52,20 @@ DOMCanvasFactory.prototype = {
} }
}; };
var DOMCMapReaderFactory = (function DOMCMapReaderFactoryClosure() { class DOMCMapReaderFactory {
function DOMCMapReaderFactory(params) { constructor({ baseUrl = null, isCompressed = false, }) {
this.baseUrl = params.baseUrl || null; this.baseUrl = baseUrl;
this.isCompressed = params.isCompressed || false; this.isCompressed = isCompressed;
} }
DOMCMapReaderFactory.prototype = { fetch({ name, }) {
fetch(params) {
var name = params.name;
if (!name) { if (!name) {
return Promise.reject(new Error('CMap name must be specified.')); return Promise.reject(new Error('CMap name must be specified.'));
} }
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
var url = this.baseUrl + name + (this.isCompressed ? '.bcmap' : ''); let url = this.baseUrl + name + (this.isCompressed ? '.bcmap' : '');
var request = new XMLHttpRequest(); let request = new XMLHttpRequest();
request.open('GET', url, true); request.open('GET', url, true);
if (this.isCompressed) { if (this.isCompressed) {
@ -78,7 +76,7 @@ var DOMCMapReaderFactory = (function DOMCMapReaderFactoryClosure() {
return; return;
} }
if (request.status === 200 || request.status === 0) { if (request.status === 200 || request.status === 0) {
var data; let data;
if (this.isCompressed && request.response) { if (this.isCompressed && request.response) {
data = new Uint8Array(request.response); data = new Uint8Array(request.response);
} else if (!this.isCompressed && request.responseText) { } else if (!this.isCompressed && request.responseText) {
@ -100,11 +98,8 @@ var DOMCMapReaderFactory = (function DOMCMapReaderFactoryClosure() {
request.send(null); request.send(null);
}); });
}, }
}; }
return DOMCMapReaderFactory;
})();
/** /**
* Optimised CSS custom property getter/setter. * Optimised CSS custom property getter/setter.

13
test/unit/test_utils.js
View File

@ -16,20 +16,19 @@
import { CMapCompressionType } from '../../src/shared/util'; import { CMapCompressionType } from '../../src/shared/util';
class NodeCMapReaderFactory { class NodeCMapReaderFactory {
constructor(params) { constructor({ baseUrl = null, isCompressed = false, }) {
this.baseUrl = params.baseUrl || null; this.baseUrl = baseUrl;
this.isCompressed = params.isCompressed || false; this.isCompressed = isCompressed;
} }
fetch(params) { fetch({ name, }) {
var name = params.name;
if (!name) { if (!name) {
return Promise.reject(new Error('CMap name must be specified.')); return Promise.reject(new Error('CMap name must be specified.'));
} }
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
var url = this.baseUrl + name + (this.isCompressed ? '.bcmap' : ''); let url = this.baseUrl + name + (this.isCompressed ? '.bcmap' : '');
var fs = require('fs'); let fs = require('fs');
fs.readFile(url, (error, data) => { fs.readFile(url, (error, data) => {
if (error || !data) { if (error || !data) {
reject(new Error('Unable to load ' + reject(new Error('Unable to load ' +