Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Replace value === (value | 0) checks with Number.isInteger(value) in the web/ folder

Browse Source 
Rather than doing what (at first) may seem like a fairly obscure comparison, using `Number.isInteger` will clearly indicate the intent of the code.
This commit is contained in:
Jonas Jenwald 2017-09-03 13:08:50 +02:00
parent 8686baede5
commit 30b7a0f093
3 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
web/pdf_link_service.js
View File

@ -98,7 +98,7 @@ class PDFLinkService {
}); });
return; return;
} }
} else if ((destRef | 0) === destRef) { // Integer } else if (Number.isInteger(destRef)) {
pageNumber = destRef + 1; pageNumber = destRef + 1;
} else { } else {
console.error(`PDFLinkService.navigateTo: "${destRef}" is not ` + console.error(`PDFLinkService.navigateTo: "${destRef}" is not ` +
@ -359,9 +359,8 @@ function isValidExplicitDestination(dest) {
} }
let page = dest[0]; let page = dest[0];
if (!(typeof page === 'object' && if (!(typeof page === 'object' &&
typeof page.num === 'number' && (page.num | 0) === page.num && Number.isInteger(page.num) && Number.isInteger(page.gen)) &&
typeof page.gen === 'number' && (page.gen | 0) === page.gen) && !(Number.isInteger(page) && page >= 0)) {
!(typeof page === 'number' && (page | 0) === page && page >= 0)) {
return false; return false;
} }
let zoom = dest[1]; let zoom = dest[1];

2
web/pdf_viewer.js
View File

@ -159,7 +159,7 @@ class PDFViewer {
* @param {number} val - The page number. * @param {number} val - The page number.
*/ */
set currentPageNumber(val) { set currentPageNumber(val) {
if ((val | 0) !== val) { // Ensure that `val` is an integer. if (!Number.isInteger(val)) {
throw new Error('Invalid page number.'); throw new Error('Invalid page number.');
} }
if (!this.pdfDocument) { if (!this.pdfDocument) {

2
web/preferences.js
View File

@ -141,7 +141,7 @@ class BasePreferences {
`expected a ${defaultType}.`); `expected a ${defaultType}.`);
} }
} else { } else {
if (valueType === 'number' && (value | 0) !== value) { if (valueType === 'number' && !Number.isInteger(value)) {
throw new Error(`Set preference: "${value}" must be an integer.`); throw new Error(`Set preference: "${value}" must be an integer.`);
} }
} }