Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Regression] Prevent breaking errors when opening a new document in the GENERIC viewer (PR 14158 follow-up)

Browse Source 
In the GENERIC viewer, e.g. when dragging-and-dropping a new PDF document which automatically opens the outline, there can now be breaking errors in the `{BaseViewer, PDFThumbnailViewer}.#getScrollAhead` methods since there's no visible pages/thumbs during loading; sorry about the breakage!
This commit is contained in:
Jonas Jenwald 2021-10-25 14:20:24 +02:00
parent 1ab9a6e36e
commit 2c779a8fbe
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
web/base_viewer.js
View File

@ -1361,10 +1361,10 @@ class BaseViewer {
return promise;
}
#getScrollAhead(views) {
if (views.first.id === 1) {
#getScrollAhead(visible) {
if (visible.first?.id === 1) {
return true;
} else if (views.last.id === this.pagesCount) {
} else if (visible.last?.id === this.pagesCount) {
return false;
}
switch (this._scrollMode) {

6
web/pdf_thumbnail_viewer.js
View File

@ -295,10 +295,10 @@ class PDFThumbnailViewer {
return promise;
}
#getScrollAhead(views) {
if (views.first.id === 1) {
#getScrollAhead(visible) {
if (visible.first?.id === 1) {
return true;
} else if (views.last.id === this._thumbnails.length) {
} else if (visible.last?.id === this._thumbnails.length) {
return false;
}
return this.scroll.down;