Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove the unused dataset checks from the scrollIntoView helper function

Browse Source 
This code was added in PR 3968, apparently in order to fix scrolling of search results in HiDPI-mode.
However, after PR 4570 nothing is setting these `dataset`-properties any more and this is thus dead code which should be removed. (If that change had broken scrolling of search results in HiDPI-mode, you'd really expect that it'd been reported and fixed a long time ago.)
This commit is contained in:
Jonas Jenwald 2021-06-03 11:11:27 +02:00
parent 9165dc0659
commit 2a35b39c46
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
web/ui_utils.js
View File

@ -117,12 +117,9 @@ function scrollIntoView(element, spot, skipOverflowHiddenElements = false) {
(skipOverflowHiddenElements && (skipOverflowHiddenElements &&
getComputedStyle(parent).overflow === "hidden") getComputedStyle(parent).overflow === "hidden")
) { ) {
if (parent.dataset._scaleY) {
offsetY /= parent.dataset._scaleY;
offsetX /= parent.dataset._scaleX;
}
offsetY += parent.offsetTop; offsetY += parent.offsetTop;
offsetX += parent.offsetLeft; offsetX += parent.offsetLeft;
parent = parent.offsetParent; parent = parent.offsetParent;
if (!parent) { if (!parent) {
return; // no need to scroll return; // no need to scroll