Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #15945 from Snuffleupagus/issue-15942

Browse Source 
[JBIG2] Ensure that the `decodeInteger` function returns valid integers (issue 15942)
This commit is contained in:
Jonas Jenwald 2023-01-19 21:14:47 +01:00 committed by GitHub
commit 29cd5ab24e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/core/jbig2.js
View File

@ -52,6 +52,9 @@ class DecodingContext {
}
}
const MAX_INT_32 = 2 ** 31 - 1;
const MIN_INT_32 = -(2 ** 31);
// Annex A. Arithmetic Integer Decoding Procedure
// A.2 Procedure for decoding values
function decodeInteger(contextCache, procedure, decoder) {
@ -83,10 +86,15 @@ function decodeInteger(contextCache, procedure, decoder) {
readBits(4) + 4) :
readBits(2);
/* eslint-enable no-nested-ternary */
let signedValue;
if (sign === 0) {
return value;
signedValue = value;
} else if (value > 0) {
return -value;
signedValue = -value;
}
// Ensure that the integer value doesn't underflow or overflow.
if (signedValue >= MIN_INT_32 && signedValue <= MAX_INT_32) {
return signedValue;
}
return null;
}

1
test/pdfs/issue15942.pdf.link Normal file
View File

@ -0,0 +1 @@
https://github.com/mozilla/pdf.js/files/10455335/3024388_99997342-a484-416f-9eb9-9a796ada1e2c.pdf

8
test/test_manifest.json
View File

@ -2002,6 +2002,14 @@
"rounds": 1,
"type": "eq"
},
{ "id": "issue15942",
"file": "pdfs/issue15942.pdf",
"md5": "d690e16e6a3a8486ebf7289a9c43ba39",
"rounds": 1,
"link": true,
"lastPage": 1,
"type": "eq"
},
{ "id": "bug1046314",
"file": "pdfs/bug1046314.pdf",
"md5": "fc658439f44cd2dd27c8bee7e7a8344e",