Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Editor] Slightly postpone the move in the DOM in order to not block the UI (bug 1854991)

Browse Source
This commit is contained in:
Calixte Denizet 2023-09-25 17:16:27 +02:00
parent 57d196e349
commit 29bc103fad
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/display/editor/editor.js
View File

@ -59,6 +59,8 @@ class AnnotationEditor {
#isInEditMode = false; #isInEditMode = false;
#moveInDOMTimeout = null;
_initialOptions = Object.create(null); _initialOptions = Object.create(null);
_uiManager = null; _uiManager = null;
@ -1046,7 +1048,16 @@ class AnnotationEditor {
} }
moveInDOM() { moveInDOM() {
this.parent?.moveEditorInDOM(this); // Moving the editor in the DOM can be expensive, so we wait a bit before.
// It's important to not block the UI (for example when changing the font
// size in a FreeText).
if (this.#moveInDOMTimeout) {
clearTimeout(this.#moveInDOMTimeout);
}
this.#moveInDOMTimeout = setTimeout(() => {
this.#moveInDOMTimeout = null;
this.parent?.moveEditorInDOM(this);
}, 0);
} }
_setParentAndPosition(parent, x, y) { _setParentAndPosition(parent, x, y) {
@ -1253,6 +1264,10 @@ class AnnotationEditor {
this.#altTextButton?.remove(); this.#altTextButton?.remove();
this.#altTextButton = null; this.#altTextButton = null;
this.#altTextTooltip = null; this.#altTextTooltip = null;
if (this.#moveInDOMTimeout) {
clearTimeout(this.#moveInDOMTimeout);
this.#moveInDOMTimeout = null;
}
} }
/** /**