Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #16784 from calixteman/editor_fix_rescale_svg

Browse Source 
[Editor] Use a getter and not a function for the _checkIfSVGFitsInCanvas (bug 1846727)
This commit is contained in:
calixteman 2023-08-03 10:16:28 +02:00 committed by GitHub
commit 2747928a54
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/display/editor/tools.js
View File

@ -75,7 +75,7 @@ class ImageManager {
#cache = null;
static _checkIfSVGFitsInCanvas() {
static get _isSVGFittingCanvas() {
// By default, Firefox doesn't rescale without preserving the aspect ratio
// when drawing an SVG image on a canvas, see https://bugzilla.mozilla.org/1547776.
// The "workaround" is to append "svgView(preserveAspectRatio(none))" to the
@ -91,7 +91,7 @@ class ImageManager {
return new Uint32Array(ctx.getImageData(0, 0, 1, 1).data.buffer)[0] === 0;
});
return shadow(this, "_checkIfSVGFitsInCanvas", promise);
return shadow(this, "_isSVGFittingCanvas", promise);
}
async #get(key, rawData) {
@ -128,8 +128,7 @@ class ImageManager {
if (image.type === "image/svg+xml") {
// Unfortunately, createImageBitmap doesn't work with SVG images.
// (see https://bugzilla.mozilla.org/1841972).
const mustRemoveAspectRatioPromise =
ImageManager._checkIfSVGFitsInCanvas();
const mustRemoveAspectRatioPromise = ImageManager._isSVGFittingCanvas;
const fileReader = new FileReader();
const imageElement = new Image();
const imagePromise = new Promise((resolve, reject) => {