Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #13837 from timvandermeij/unit-test-query-string

Browse Source 
Implement unit tests for the `parseQueryString` utility function
This commit is contained in:
Tim van der Meij 2021-08-01 14:26:33 +02:00 committed by GitHub
commit 273cea8675
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 40 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
test/unit/ui_utils_spec.js
View File

@ -22,6 +22,7 @@ import {
isPortraitOrientation,
isValidRotation,
moveToEndOfArray,
parseQueryString,
waitOnEventOrTimeout,
WaitOnType,
} from "../../web/ui_utils.js";
@ -253,6 +254,43 @@ describe("ui_utils", function () {
});
});
describe("parseQueryString", function () {
it("should parse one key/value pair", function () {
const parameters = parseQueryString("key1=value1");
expect(parameters.size).toEqual(1);
expect(parameters.get("key1")).toEqual("value1");
});
it("should parse multiple key/value pairs", function () {
const parameters = parseQueryString(
"key1=value1&key2=value2&key3=value3"
);
expect(parameters.size).toEqual(3);
expect(parameters.get("key1")).toEqual("value1");
expect(parameters.get("key2")).toEqual("value2");
expect(parameters.get("key3")).toEqual("value3");
});
it("should parse keys without values", function () {
const parameters = parseQueryString("key1");
expect(parameters.size).toEqual(1);
expect(parameters.get("key1")).toEqual("");
});
it("should decode encoded key/value pairs", function () {
const parameters = parseQueryString("k%C3%ABy1=valu%C3%AB1");
expect(parameters.size).toEqual(1);
expect(parameters.get("këy1")).toEqual("valuë1");
});
it("should convert keys to lowercase", function () {
const parameters = parseQueryString("Key1=Value1&KEY2=Value2");
expect(parameters.size).toEqual(2);
expect(parameters.get("key1")).toEqual("Value1");
expect(parameters.get("key2")).toEqual("Value2");
});
});
describe("waitOnEventOrTimeout", function () {
let eventBus;

5
web/ui_utils.js
View File

@ -185,10 +185,9 @@ function watchScroll(viewAreaElement, callback) {
* @returns {Map}
*/
function parseQueryString(query) {
const parts = query.split("&");
const params = new Map();
for (let i = 0, ii = parts.length; i < ii; ++i) {
const param = parts[i].split("="),
for (const part of query.split("&")) {
const param = part.split("="),
key = param[0].toLowerCase(),
value = param.length > 1 ? param[1] : "";
params.set(decodeURIComponent(key), decodeURIComponent(value));