From 2608757620d08a850123b8dab34afc209518dbcc Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Sat, 11 Jul 2015 12:09:00 +0200 Subject: [PATCH] Simplify the code that resets the value of the `pageNumber` element in `PDFViewerApplication.setInitialView` After the creation of `PDFViewer`, its `_resetView` method takes care of resetting, among other things, the page number property. Hence we don't need to set `pdfViewer.currentPageNumber = 1;` here any more, and the comment is no longer accurate either. --- web/viewer.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/web/viewer.js b/web/viewer.js index 976c9d332..5f5e0b14e 100644 --- a/web/viewer.js +++ b/web/viewer.js @@ -954,11 +954,10 @@ var PDFViewerApplication = { setInitialView: function pdfViewSetInitialView(storedHash, scale) { this.isInitialViewSet = true; - // When opening a new file (when one is already loaded in the viewer): - // Reset 'currentPageNumber', since otherwise the page's scale will be wrong - // if 'currentPageNumber' is larger than the number of pages in the file. + // When opening a new file, when one is already loaded in the viewer, + // ensure that the 'pageNumber' element displays the correct value. document.getElementById('pageNumber').value = - this.pdfViewer.currentPageNumber = 1; + this.pdfViewer.currentPageNumber; if (this.initialDestination) { this.pdfLinkService.navigateTo(this.initialDestination);