Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[api-minor] Stop "supporting" binary data provided as Buffer in Node.js environments (PR 16055 follow-up)

Browse Source 
Given that the PDF.js library has never officially supported/documented that binary data can be provided as a `Buffer`, and that it's been explicitly deprecated in *four* releases, it seems reasonable that we outright reject such data instead (to reduce the amount of Node.js specific code-paths).
This commit is contained in:
Jonas Jenwald 2023-07-01 10:29:21 +02:00
parent ac937a9b3c
commit 25bac064d8
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/display/api.js
View File

@ -549,10 +549,9 @@ function getDataProp(val) {
typeof Buffer !== "undefined" && // eslint-disable-line no-undef typeof Buffer !== "undefined" && // eslint-disable-line no-undef
val instanceof Buffer // eslint-disable-line no-undef val instanceof Buffer // eslint-disable-line no-undef
) { ) {
deprecated( throw new Error(
"Please provide binary data as `Uint8Array`, rather than `Buffer`." "Please provide binary data as `Uint8Array`, rather than `Buffer`."
); );
return new Uint8Array(val);
} }
if (val instanceof Uint8Array && val.byteLength === val.buffer.byteLength) { if (val instanceof Uint8Array && val.byteLength === val.buffer.byteLength) {
// Use the data as-is when it's already a Uint8Array that completely // Use the data as-is when it's already a Uint8Array that completely