Remove the "Page: " label and replace it with a tooltip
The following reasoning was used for deciding to remove the "Page: " label, and replace it with a tooltip, from the main toolbar: - We have no other visible labels in the *main* toolbar (e.g. the Zoom dropdown doesn't have a label, but only a tooltip). - We already hide the "Page: " label when the viewer is narrow. - The varying width of the "Page: " label in different locales is already causing issues for many languages, with overlap in the main toolbar as a result. Trying to create responsive CSS styles that works well in all locales is already difficult, and if we add support for page labels that will only further compound the issues. - Some PDF viewers (e.g. Adobe Reader, pdfium in Chrome) doesn't show labels in the UI by default.
This commit is contained in:
parent
47a1c7797e
commit
23ec02bb93
@ -18,11 +18,10 @@ previous_label=Previous
|
|||||||
next.title=Next Page
|
next.title=Next Page
|
||||||
next_label=Next
|
next_label=Next
|
||||||
|
|
||||||
# LOCALIZATION NOTE (page_label, page_of):
|
# LOCALIZATION NOTE (page.title): The tooltip for the pageNumber input.
|
||||||
# These strings are concatenated to form the "Page: X of Y" string.
|
page.title=Page
|
||||||
# Do not translate "{{pageCount}}", it will be substituted with a number
|
# LOCALIZATION NOTE (page_of): "{{pageCount}}" will be replaced by a number
|
||||||
# representing the total number of pages.
|
# representing the total number of pages in the document.
|
||||||
page_label=Page:
|
|
||||||
page_of=of {{pageCount}}
|
page_of=of {{pageCount}}
|
||||||
|
|
||||||
zoom_out.title=Zoom Out
|
zoom_out.title=Zoom Out
|
||||||
|
@ -18,11 +18,10 @@ previous_label=Föregående
|
|||||||
next.title=Nästa sida
|
next.title=Nästa sida
|
||||||
next_label=Nästa
|
next_label=Nästa
|
||||||
|
|
||||||
# LOCALIZATION NOTE (page_label, page_of):
|
# LOCALIZATION NOTE (page.title): The tooltip for the pageNumber input.
|
||||||
# These strings are concatenated to form the "Page: X of Y" string.
|
page.title=Sida
|
||||||
# Do not translate "{{pageCount}}", it will be substituted with a number
|
# LOCALIZATION NOTE (page_of): "{{pageCount}}" will be replaced by a number
|
||||||
# representing the total number of pages.
|
# representing the total number of pages in the document.
|
||||||
page_label=Sida:
|
|
||||||
page_of=av {{pageCount}}
|
page_of=av {{pageCount}}
|
||||||
|
|
||||||
zoom_out.title=Zooma ut
|
zoom_out.title=Zooma ut
|
||||||
|
@ -1939,7 +1939,7 @@ html[dir='rtl'] #documentPropertiesOverlay .row > * {
|
|||||||
}
|
}
|
||||||
|
|
||||||
@media all and (max-width: 510px) {
|
@media all and (max-width: 510px) {
|
||||||
#scaleSelectContainer, #pageNumberLabel {
|
#scaleSelectContainer {
|
||||||
display: none;
|
display: none;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -194,8 +194,7 @@ See https://github.com/adobe-type-tools/cmap-resources
|
|||||||
<span data-l10n-id="next_label">Next</span>
|
<span data-l10n-id="next_label">Next</span>
|
||||||
</button>
|
</button>
|
||||||
</div>
|
</div>
|
||||||
<label id="pageNumberLabel" class="toolbarLabel" for="pageNumber" data-l10n-id="page_label">Page: </label>
|
<input type="number" id="pageNumber" class="toolbarField pageNumber" title="Page" value="1" size="4" min="1" tabindex="15" data-l10n-id="page">
|
||||||
<input type="number" id="pageNumber" class="toolbarField pageNumber" value="1" size="4" min="1" tabindex="15">
|
|
||||||
<span id="numPages" class="toolbarLabel"></span>
|
<span id="numPages" class="toolbarLabel"></span>
|
||||||
</div>
|
</div>
|
||||||
<div id="toolbarViewerRight">
|
<div id="toolbarViewerRight">
|
||||||
|
Loading…
x
Reference in New Issue
Block a user