Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Removes Stats dependency from PDFPageView.

Browse Source
This commit is contained in:
Yury Delendik 2014-09-29 11:15:06 -05:00
parent 9f384bbb41
commit 22c62685b0
3 changed files with 17 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
web/pdf_page_view.js
View File

@ -14,8 +14,7 @@
* See the License for the specific language governing permissions and * See the License for the specific language governing permissions and
* limitations under the License. * limitations under the License.
*/ */
/* globals RenderingStates, PDFJS, CustomStyle, CSS_UNITS, getOutputScale, /* globals RenderingStates, PDFJS, CustomStyle, CSS_UNITS, getOutputScale */
Stats */
'use strict'; 'use strict';
@ -392,7 +391,6 @@ var PDFPageView = (function PDFPageViewClosure() {
self.error = error; self.error = error;
self.stats = pdfPage.stats; self.stats = pdfPage.stats;
self.updateStats();
if (self.onAfterDraw) { if (self.onAfterDraw) {
self.onAfterDraw(); self.onAfterDraw();
} }
@ -508,17 +506,6 @@ var PDFPageView = (function PDFPageViewClosure() {
}); });
}; };
}, },
updateStats: function PDFPageView_updateStats() {
if (!this.stats) {
return;
}
if (PDFJS.pdfBug && Stats.enabled) {
var stats = this.stats;
Stats.add(this.id, stats);
}
},
}; };
return PDFPageView; return PDFPageView;

1
web/pdf_viewer.js
View File

@ -107,7 +107,6 @@ var PDFViewer = (function pdfViewer() {
return; return;
} }
this.pages[val - 1].updateStats();
event.previousPageNumber = this._currentPageNumber; event.previousPageNumber = this._currentPageNumber;
this._currentPageNumber = val; this._currentPageNumber = val;
event.pageNumber = val; event.pageNumber = val;

19
web/viewer.js
View File

@ -16,7 +16,7 @@
*/ */
/* globals PDFJS, PDFBug, FirefoxCom, Stats, Cache, ProgressBar, /* globals PDFJS, PDFBug, FirefoxCom, Stats, Cache, ProgressBar,
DownloadManager, getFileName, scrollIntoView, getPDFFileNameFromURL, DownloadManager, getFileName, scrollIntoView, getPDFFileNameFromURL,
PDFHistory, Preferences, SidebarView, ViewHistory, PDFHistory, Preferences, SidebarView, ViewHistory, Stats,
PDFThumbnailViewer, URL, noContextMenuHandler, SecondaryToolbar, PDFThumbnailViewer, URL, noContextMenuHandler, SecondaryToolbar,
PasswordPrompt, PresentationMode, HandTool, Promise, PasswordPrompt, PresentationMode, HandTool, Promise,
DocumentProperties, DocumentOutlineView, DocumentAttachmentsView, DocumentProperties, DocumentOutlineView, DocumentAttachmentsView,
@ -1730,12 +1730,17 @@ function webViewerInitialized() {
document.addEventListener('DOMContentLoaded', webViewerLoad, true); document.addEventListener('DOMContentLoaded', webViewerLoad, true);
document.addEventListener('pagerendered', function (e) { document.addEventListener('pagerendered', function (e) {
var pageIndex = e.detail.pageNumber - 1; var pageNumber = e.detail.pageNumber;
var pageIndex = pageNumber - 1;
var pageView = PDFViewerApplication.pdfViewer.getPageView(pageIndex); var pageView = PDFViewerApplication.pdfViewer.getPageView(pageIndex);
var thumbnailView = PDFViewerApplication.pdfThumbnailViewer. var thumbnailView = PDFViewerApplication.pdfThumbnailViewer.
getThumbnail(pageIndex); getThumbnail(pageIndex);
thumbnailView.setImage(pageView); thumbnailView.setImage(pageView);
if (PDFJS.pdfBug && Stats.enabled && pageView.stats) {
Stats.add(pageNumber, pageView.stats);
}
//#if (FIREFOX || MOZCENTRAL) //#if (FIREFOX || MOZCENTRAL)
//if (pageView.textLayer && pageView.textLayer.textDivs && //if (pageView.textLayer && pageView.textLayer.textDivs &&
// pageView.textLayer.textDivs.length > 0 && // pageView.textLayer.textDivs.length > 0 &&
@ -1768,7 +1773,7 @@ document.addEventListener('pagerendered', function (e) {
// If the page is still visible when it has finished rendering, // If the page is still visible when it has finished rendering,
// ensure that the page number input loading indicator is hidden. // ensure that the page number input loading indicator is hidden.
if ((pageIndex + 1) === PDFViewerApplication.page) { if (pageNumber === PDFViewerApplication.page) {
var pageNumberInput = document.getElementById('pageNumber'); var pageNumberInput = document.getElementById('pageNumber');
pageNumberInput.classList.remove(PAGE_NUMBER_LOADING_INDICATOR); pageNumberInput.classList.remove(PAGE_NUMBER_LOADING_INDICATOR);
} }
@ -1965,6 +1970,14 @@ window.addEventListener('pagechange', function pagechange(evt) {
document.getElementById('firstPage').disabled = (page <= 1); document.getElementById('firstPage').disabled = (page <= 1);
document.getElementById('lastPage').disabled = (page >= numPages); document.getElementById('lastPage').disabled = (page >= numPages);
// we need to update stats
if (PDFJS.pdfBug && Stats.enabled) {
var pageView = PDFViewerApplication.pdfViewer.getPageView(page - 1);
if (pageView.stats) {
Stats.add(page, pageView.stats);
}
}
// checking if the this.page was called from the updateViewarea function // checking if the this.page was called from the updateViewarea function
if (evt.updateInProgress) { if (evt.updateInProgress) {
return; return;