Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #13657 from Snuffleupagus/rm-instanceof-Object

Browse Source 
Replace `instanceof Object` with `typeof` checks
This commit is contained in:
Tim van der Meij 2021-07-03 12:54:34 +02:00 committed by GitHub
commit 227d0b0dac
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.eslintrc
View File

@ -166,6 +166,10 @@
"no-nested-ternary": "error",
"no-new-object": "error",
"no-restricted-syntax": ["error",
{
"selector": "BinaryExpression[operator='instanceof'][right.name='Object']",
"message": "Use `typeof` rather than `instanceof Object`.",
},
{
"selector": "CallExpression[callee.name='assert'][arguments.length!=2]",
"message": "`assert()` must always be invoked with two arguments.",

2
src/core/xfa/xfa_object.js
View File

@ -586,7 +586,7 @@ class XFAObject {
if (Array.isArray(obj)) {
return obj.map(x => XFAObject[_cloneAttribute](x));
}
if (obj instanceof Object) {
if (typeof obj === "object" && obj !== null) {
return Object.assign({}, obj);
}
return obj;

2
web/pdf_link_service.js
View File

@ -114,7 +114,7 @@ class PDFLinkService {
const destRef = explicitDest[0];
let pageNumber;
if (destRef instanceof Object) {
if (typeof destRef === "object" && destRef !== null) {
pageNumber = this._cachedPageNumber(destRef);
if (pageNumber === null) {

2
web/pdf_outline_viewer.js
View File

@ -304,7 +304,7 @@ class PDFOutlineViewer extends BaseTreeViewer {
if (Array.isArray(explicitDest)) {
const [destRef] = explicitDest;
if (destRef instanceof Object) {
if (typeof destRef === "object" && destRef !== null) {
pageNumber = this.linkService._cachedPageNumber(destRef);
if (!pageNumber) {