Merge pull request #12616 from Snuffleupagus/PDFThumbnailViewer-cleanup

Improve the cleanup functionality for thumbnails
This commit is contained in:
Tim van der Meij 2020-11-14 16:24:37 +01:00 committed by GitHub
commit 1f65896093
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 7 deletions

View File

@ -502,10 +502,6 @@ class PDFThumbnailView {
}
});
}
static cleanup() {
TempImageFactory.destroyCanvas();
}
}
export { PDFThumbnailView };
export { PDFThumbnailView, TempImageFactory };

View File

@ -20,7 +20,8 @@ import {
scrollIntoView,
watchScroll,
} from "./ui_utils.js";
import { PDFThumbnailView } from "./pdf_thumbnail_view.js";
import { PDFThumbnailView, TempImageFactory } from "./pdf_thumbnail_view.js";
import { RenderingStates } from "./pdf_rendering_queue.js";
const THUMBNAIL_SCROLL_MARGIN = -19;
const THUMBNAIL_SELECTED_CLASS = "selected";
@ -156,7 +157,15 @@ class PDFThumbnailViewer {
}
cleanup() {
PDFThumbnailView.cleanup();
for (let i = 0, ii = this._thumbnails.length; i < ii; i++) {
if (
this._thumbnails[i] &&
this._thumbnails[i].renderingState !== RenderingStates.FINISHED
) {
this._thumbnails[i].reset();
}
}
TempImageFactory.destroyCanvas();
}
/**