Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use the SimpleLinkService when running "annotations" reference tests

Browse Source 
Rather than (basically) duplicating the `SimpleLinkService` in `test/driver.js`, with potential test failuires if you forget to update the test mock, it seems much nicer to just re-use the viewer component.

Note that `SimpleLinkService` is already bundled into the `build/components/pdf_viewer.js` file. Hence we only need to expose it similar to the other viewer components in that file, and make sure that the `gulp components` command runs as part of the test-setup.
This commit is contained in:
Jonas Jenwald 2017-09-12 14:29:23 +02:00
parent f2618eb2e4
commit 1ebbdc253a
4 changed files with 9 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
gulpfile.js
View File

@ -1085,22 +1085,22 @@ gulp.task('publish', ['generic'], function (done) {
}); });
}); });
gulp.task('test', ['generic'], function () { gulp.task('test', ['generic', 'components'], function () {
return streamqueue({ objectMode: true, }, return streamqueue({ objectMode: true, },
createTestSource('unit'), createTestSource('browser')); createTestSource('unit'), createTestSource('browser'));
}); });
gulp.task('bottest', ['generic'], function () { gulp.task('bottest', ['generic', 'components'], function () {
return streamqueue({ objectMode: true, }, return streamqueue({ objectMode: true, },
createTestSource('unit'), createTestSource('font'), createTestSource('unit'), createTestSource('font'),
createTestSource('browser (no reftest)')); createTestSource('browser (no reftest)'));
}); });
gulp.task('browsertest', ['generic'], function () { gulp.task('browsertest', ['generic', 'components'], function () {
return createTestSource('browser'); return createTestSource('browser');
}); });
gulp.task('unittest', ['generic'], function () { gulp.task('unittest', ['generic', 'components'], function () {
return createTestSource('unit'); return createTestSource('unit');
}); });
@ -1108,11 +1108,11 @@ gulp.task('fonttest', function () {
return createTestSource('font'); return createTestSource('font');
}); });
gulp.task('makeref', ['generic'], function (done) { gulp.task('makeref', ['generic', 'components'], function (done) {
makeRef(done); makeRef(done);
}); });
gulp.task('botmakeref', ['generic'], function (done) { gulp.task('botmakeref', ['generic', 'components'], function (done) {
makeRef(done, true); makeRef(done, true);
}); });

37
test/driver.js
View File

@ -21,41 +21,6 @@ var PDF_TO_CSS_UNITS = 96.0 / 72.0;
var StatTimer = pdfjsDistBuildPdf.StatTimer; var StatTimer = pdfjsDistBuildPdf.StatTimer;
/**
* @class
*/
var LinkServiceMock = (function LinkServiceMockClosure() {
function LinkServiceMock() {}
LinkServiceMock.prototype = {
get page() {
return 0;
},
set page(value) {},
navigateTo(dest) {},
getDestinationHash(dest) {
return '#';
},
getAnchorUrl(hash) {
return '#';
},
setHash(hash) {},
executeNamedAction(action) {},
onFileAttachmentAnnotation(params) {},
cachePageRef(pageNum, pageRef) {},
};
return LinkServiceMock;
})();
/** /**
* @class * @class
*/ */
@ -230,7 +195,7 @@ var rasterizeAnnotationLayer = (function rasterizeAnnotationLayerClosure() {
div, div,
annotations, annotations,
page, page,
linkService: new LinkServiceMock(), linkService: new PDFJS.SimpleLinkService(),
renderInteractiveForms, renderInteractiveForms,
}; };
PDFJS.AnnotationLayer.render(parameters); PDFJS.AnnotationLayer.render(parameters);

1
test/test_slave.html
View File

@ -19,6 +19,7 @@ limitations under the License.
<title>PDF.js test slave</title> <title>PDF.js test slave</title>
<meta charset="utf-8"> <meta charset="utf-8">
<script src="../build/generic/build/pdf.js"></script> <script src="../build/generic/build/pdf.js"></script>
<script src="../build/components/pdf_viewer.js"></script>
<script src="driver.js"></script> <script src="driver.js"></script>
</head> </head>
<body> <body>

1
web/pdf_viewer.component.js
View File

@ -32,6 +32,7 @@ var PDFJS = pdfjsLib.PDFJS;
PDFJS.PDFViewer = pdfjsWebPDFViewer.PDFViewer; PDFJS.PDFViewer = pdfjsWebPDFViewer.PDFViewer;
PDFJS.PDFPageView = pdfjsWebPDFPageView.PDFPageView; PDFJS.PDFPageView = pdfjsWebPDFPageView.PDFPageView;
PDFJS.PDFLinkService = pdfjsWebPDFLinkService.PDFLinkService; PDFJS.PDFLinkService = pdfjsWebPDFLinkService.PDFLinkService;
PDFJS.SimpleLinkService = pdfjsWebPDFLinkService.SimpleLinkService;
PDFJS.TextLayerBuilder = pdfjsWebTextLayerBuilder.TextLayerBuilder; PDFJS.TextLayerBuilder = pdfjsWebTextLayerBuilder.TextLayerBuilder;
PDFJS.DefaultTextLayerFactory = PDFJS.DefaultTextLayerFactory =
pdfjsWebTextLayerBuilder.DefaultTextLayerFactory; pdfjsWebTextLayerBuilder.DefaultTextLayerFactory;