From 1c4af2727c6d8ed7fa1c4dd73d8f80e4cb3db6c3 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Thu, 26 Jan 2023 14:08:40 +0100 Subject: [PATCH] Simplify setting the `GlobalWorkerOptions` default values (PR 9480 follow-up) There's really no need for these "complicated" default value assignments, since `GlobalWorkerOptions` is a local variable at this point, and this is rather a case of too much copy-and-paste. Note that years ago, when all options were set using a global `PDFJS` object, it's possible that options had been set (from the outside) *before* the object had been properly initialized; see e.g. https://github.com/mozilla/pdf.js/blob/a89071bdefb90733fc2e671fcca61f6d03964e04/src/display/global.js --- src/display/worker_options.js | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/display/worker_options.js b/src/display/worker_options.js index af53729af..1e82a4f7e 100644 --- a/src/display/worker_options.js +++ b/src/display/worker_options.js @@ -27,14 +27,7 @@ /** @type {GlobalWorkerOptionsType} */ const GlobalWorkerOptions = Object.create(null); -GlobalWorkerOptions.workerPort = - GlobalWorkerOptions.workerPort === undefined - ? null - : GlobalWorkerOptions.workerPort; - -GlobalWorkerOptions.workerSrc = - GlobalWorkerOptions.workerSrc === undefined - ? "" - : GlobalWorkerOptions.workerSrc; +GlobalWorkerOptions.workerPort = null; +GlobalWorkerOptions.workerSrc = ""; export { GlobalWorkerOptions };