Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Factor out repeated Ref key string generation code.

Browse Source 
In src/core/obj.js, we convert a Ref to a string to index into a table like
this: 'R1.0'.  This conversion is repeated numerous times.

This patch factors out the conversion into a new function.
Ref.prototype.toString().
This commit is contained in:
Nicholas Nethercote 2014-06-18 20:41:33 -07:00
parent cf4bc42e33
commit 1ad3ffbc7b
1 changed files with 14 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/core/obj.js
View File

@ -218,7 +218,11 @@ var Ref = (function RefClosure() {
this.gen = gen;
}
Ref.prototype = {};
Ref.prototype = {
toString: function Ref_toString() {
return 'R' + this.num + '.' + this.gen;
}
};
return Ref;
})();
@ -232,15 +236,15 @@ var RefSet = (function RefSetClosure() {
RefSet.prototype = {
has: function RefSet_has(ref) {
return ('R' + ref.num + '.' + ref.gen) in this.dict;
return ref.toString() in this.dict;
},
put: function RefSet_put(ref) {
this.dict['R' + ref.num + '.' + ref.gen] = true;
this.dict[ref.toString()] = true;
},
remove: function RefSet_remove(ref) {
delete this.dict['R' + ref.num + '.' + ref.gen];
delete this.dict[ref.toString()];
}
};
@ -254,19 +258,19 @@ var RefSetCache = (function RefSetCacheClosure() {
RefSetCache.prototype = {
get: function RefSetCache_get(ref) {
return this.dict['R' + ref.num + '.' + ref.gen];
return this.dict[ref.toString()];
},
has: function RefSetCache_has(ref) {
return ('R' + ref.num + '.' + ref.gen) in this.dict;
return ref.toString() in this.dict;
},
put: function RefSetCache_put(ref, obj) {
this.dict['R' + ref.num + '.' + ref.gen] = obj;
this.dict[ref.toString()] = obj;
},
putAlias: function RefSetCache_putAlias(ref, aliasRef) {
this.dict['R' + ref.num + '.' + ref.gen] = this.get(aliasRef);
this.dict[ref.toString()] = this.get(aliasRef);
},
forEach: function RefSetCache_forEach(fn, thisArg) {
@ -1180,9 +1184,9 @@ var XRef = (function XRefClosure() {
xrefEntry = this.fetchCompressed(xrefEntry, suppressEncryption);
}
if (isDict(xrefEntry)){
xrefEntry.objId = 'R' + ref.num + '.' + ref.gen;
xrefEntry.objId = ref.toString();
} else if (isStream(xrefEntry)) {
xrefEntry.dict.objId = 'R' + ref.num + '.' + ref.gen;
xrefEntry.dict.objId = ref.toString();
}
return xrefEntry;
},