Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix of combineUrl(baseUrl, url) in case of url - null, empty, undefined + unittests

Browse Source
This commit is contained in:
khodzha 2012-11-24 04:22:52 +04:00
parent 1e7100db1e
commit 18da086b96
2 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/util.js
View File

@ -85,6 +85,8 @@ function assert(cond, msg) {
// Combines two URLs. The baseUrl shall be absolute URL. If the url is an
// absolute URL, it will be returned as is.
function combineUrl(baseUrl, url) {
if (!url)
return baseUrl;
if (url.indexOf(':') >= 0)
return url;
if (url.charAt(0) == '/') {

16
test/unit/util_spec.js
View File

@ -45,6 +45,22 @@ describe('util', function() {
var expected = 'http://server/test2.html';
expect(result).toEqual(expected);
});
it('returns base url when url is empty', function() {
var baseUrl = 'http://server/index.html';
var url = '';
var result = combineUrl(baseUrl, url);
var expected = 'http://server/index.html';
expect(result).toEqual(expected);
});
it('returns base url when url is undefined', function() {
var baseUrl = 'http://server/index.html';
var url;
var result = combineUrl(baseUrl, url);
var expected = 'http://server/index.html';
expect(result).toEqual(expected);
});
});
});