From 18c295f3d8f7b2268ee1906e7681a16a769a7d56 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Sun, 30 Jan 2022 18:24:22 +0100 Subject: [PATCH] Disable the browser-tests, during `gulp makeref`, in Google Chrome on the Windows bot (PR 14392 follow-up) Either the latest Chromium update, the latest Puppeteer update, or a combination of them both are now causing the Windows bot to timeout during the browser-tests; please see PR 14392. --- gulpfile.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/gulpfile.js b/gulpfile.js index 2f6b96154..d586571e6 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -607,11 +607,18 @@ function makeRef(done, bot) { console.log(); console.log("### Creating reference images"); + let forceNoChrome = false; const args = ["test.js", "--masterMode"]; if (bot) { + const os = process.env.OS; + if (/windows/i.test(os)) { + // The browser-tests are too slow in Google Chrome on the Windows + // bot, causing a timeout, hence disabling them for now. + forceNoChrome = true; + } args.push("--noPrompts", "--strictVerify"); } - if (process.argv.includes("--noChrome")) { + if (process.argv.includes("--noChrome") || forceNoChrome) { args.push("--noChrome"); }