Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #7979 from Snuffleupagus/eslint-more-rules

Browse Source 
Enable the `no-unsafe-finally`/`no-octal`/`no-useless-call` ESLint rules
This commit is contained in:
Tim van der Meij 2017-01-22 20:53:26 +01:00 committed by GitHub
commit 17dd2e6b20
3 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.eslintrc
View File

@ -36,6 +36,7 @@
"no-sparse-arrays": "error", "no-sparse-arrays": "error",
"no-unexpected-multiline": "error", "no-unexpected-multiline": "error",
"no-unreachable": "error", "no-unreachable": "error",
"no-unsafe-finally": "error",
"no-unsafe-negation": "error", "no-unsafe-negation": "error",
"use-isnan": "error", "use-isnan": "error",
"valid-typeof": ["error", { "requireStringLiterals": true, }], "valid-typeof": ["error", { "requireStringLiterals": true, }],
@ -60,10 +61,12 @@
"no-new-wrappers": "error", "no-new-wrappers": "error",
"no-new": "error", "no-new": "error",
"no-octal-escape": "error", "no-octal-escape": "error",
"no-octal": "error",
"no-redeclare": "error", "no-redeclare": "error",
"no-self-assign": "error", "no-self-assign": "error",
"no-unused-expressions": "error", "no-unused-expressions": "error",
"no-unused-labels": "error", "no-unused-labels": "error",
"no-useless-call": "error",
"no-useless-concat": "error", "no-useless-concat": "error",
"wrap-iife": ["error", "any"], "wrap-iife": ["error", "any"],
"yoda": ["error", "never", { "onlyEquality": true, }], "yoda": ["error", "never", { "onlyEquality": true, }],

2
src/display/api.js
View File

@ -2108,7 +2108,7 @@ var InternalRenderTask = (function InternalRenderTaskClosure() {
return; return;
} }
if (this.task.onContinue) { if (this.task.onContinue) {
this.task.onContinue.call(this.task, this._scheduleNextBound); this.task.onContinue(this._scheduleNextBound);
} else { } else {
this._scheduleNext(); this._scheduleNext();
} }

2
web/pdf_print_service.js
View File

@ -237,7 +237,7 @@
if (OverlayManager.active === 'printServiceOverlay') { if (OverlayManager.active === 'printServiceOverlay') {
OverlayManager.close('printServiceOverlay'); OverlayManager.close('printServiceOverlay');
} }
return; return; // eslint-disable-line no-unsafe-finally
} }
var activeServiceOnEntry = activeService; var activeServiceOnEntry = activeService;
activeService.renderPages().then(function () { activeService.renderPages().then(function () {