Merge pull request #7979 from Snuffleupagus/eslint-more-rules

Enable the `no-unsafe-finally`/`no-octal`/`no-useless-call` ESLint rules

.eslintrc

@@ -36,6 +36,7 @@
     "no-sparse-arrays": "error",
     "no-unexpected-multiline": "error",
     "no-unreachable": "error",
+    "no-unsafe-finally": "error",
     "no-unsafe-negation": "error",
     "use-isnan": "error",
     "valid-typeof": ["error", { "requireStringLiterals": true, }],
@@ -60,10 +61,12 @@
     "no-new-wrappers": "error",
     "no-new": "error",
     "no-octal-escape": "error",
+    "no-octal": "error",
     "no-redeclare": "error",
     "no-self-assign": "error",
     "no-unused-expressions": "error",
     "no-unused-labels": "error",
+    "no-useless-call": "error",
     "no-useless-concat": "error",
     "wrap-iife": ["error", "any"],
     "yoda": ["error", "never", { "onlyEquality": true, }],

src/display/api.js

@@ -2108,7 +2108,7 @@ var InternalRenderTask = (function InternalRenderTaskClosure() {
         return;
       }
       if (this.task.onContinue) {
-        this.task.onContinue.call(this.task, this._scheduleNextBound);
+        this.task.onContinue(this._scheduleNextBound);
       } else {
         this._scheduleNext();
       }

web/pdf_print_service.js

@@ -237,7 +237,7 @@
         if (OverlayManager.active === 'printServiceOverlay') {
           OverlayManager.close('printServiceOverlay');
         }
-        return;
+        return; // eslint-disable-line no-unsafe-finally
       }
       var activeServiceOnEntry = activeService;
       activeService.renderPages().then(function () {