Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove useless wrapReason calls in the MessageHandler class

Browse Source 
Currently `wrapReason` is manually called at *every* `resolveOrReject` call-site, despite it being completely unnecessary unless there's an actual error being handled. This is obviously inefficient, and it's easy enough to avoid by having `resolveOrReject` handle this only when actually needed.
This commit is contained in:
Jonas Jenwald 2019-07-13 13:08:29 +02:00
parent 421bf62849
commit 17116917f7
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/shared/message_handler.js
View File

@ -52,11 +52,11 @@ function makeReasonSerializable(reason) {
return new UnknownErrorException(reason.message, reason.toString()); return new UnknownErrorException(reason.message, reason.toString());
} }
function resolveOrReject(capability, success, reason) { function resolveOrReject(capability, data) {
if (success) { if (data.success) {
capability.resolve(); capability.resolve();
} else { } else {
capability.reject(reason); capability.reject(wrapReason(data.reason));
} }
} }
@ -341,12 +341,10 @@ MessageHandler.prototype = {
switch (data.stream) { switch (data.stream) {
case 'start_complete': case 'start_complete':
resolveOrReject(this.streamControllers[data.streamId].startCall, resolveOrReject(this.streamControllers[data.streamId].startCall, data);
data.success, wrapReason(data.reason));
break; break;
case 'pull_complete': case 'pull_complete':
resolveOrReject(this.streamControllers[data.streamId].pullCall, resolveOrReject(this.streamControllers[data.streamId].pullCall, data);
data.success, wrapReason(data.reason));
break; break;
case 'pull': case 'pull':
// Ignore any pull after close is called. // Ignore any pull after close is called.
@ -395,8 +393,7 @@ MessageHandler.prototype = {
deleteStreamController(); deleteStreamController();
break; break;
case 'cancel_complete': case 'cancel_complete':
resolveOrReject(this.streamControllers[data.streamId].cancelCall, resolveOrReject(this.streamControllers[data.streamId].cancelCall, data);
data.success, wrapReason(data.reason));
deleteStreamController(); deleteStreamController();
break; break;
case 'cancel': case 'cancel':