Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Firefox addon] Remove the registerAddonHistogram fallback code for Firefox versions 36 (and below) from PdfJsTelemetry-addon.jsm

Browse Source 
Given that the addon doesn't even work in Firefox versions prior to 38, this is just dead code that can now be removed.
This commit is contained in:
Jonas Jenwald 2016-12-23 12:47:33 +01:00
parent 9434c023ab
commit 15f75a5585
1 changed files with 0 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
extensions/firefox/content/PdfJsTelemetry-addon.jsm
View File

@ -25,30 +25,7 @@ Cu.import('resource://gre/modules/Services.jsm');
const ADDON_ID = 'uriloader@pdf.js';
var Telemetry = Services.telemetry;
var registerAddonHistogram = Telemetry.registerAddonHistogram;
try {
// Swapping arguments of the registerAddonHistogram for older Firefox versions.
// See https://bugzilla.mozilla.org/show_bug.cgi?id=1069953.
var ffVersion = parseInt(Services.appinfo.platformVersion);
var oldTelemetryAPI = ffVersion < 36;
if (ffVersion === 36) {
// Probing FF36 to check if it has new API.
try {
Telemetry.registerAddonHistogram(ADDON_ID, 'PDF_36',
Telemetry.HISTOGRAM_LINEAR, 1, 40, 41);
var histogram = Telemetry.getAddonHistogram(ADDON_ID, 'PDF_36');
histogram.add(36);
} catch (e) {
oldTelemetryAPI = true;
}
}
if (oldTelemetryAPI) {
registerAddonHistogram = function (p1, p2, p3, p4, p5, p6) {
return Telemetry.registerAddonHistogram(p1, p2, p4, p5, p6, p3);
};
}
} catch (ex) { }
registerAddonHistogram(ADDON_ID, 'PDF_VIEWER_USED', Telemetry.HISTOGRAM_BOOLEAN, 1, 2, 3);
registerAddonHistogram(ADDON_ID, 'PDF_VIEWER_FALLBACK_SHOWN', Telemetry.HISTOGRAM_BOOLEAN, 1, 2, 3);