Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Stop trying to sort the attachments in the sidebar

Browse Source 
Looking at the behaviour in Adobe Reader it doesn't appear that attachments are sorted alphabetically, hence it doesn't seem necessary for us to do so either in the viewer.
An additional benefit of *not* sorting the attachments is that any "actual" attachments are now always placed at the top of the list in the sidebar, and if any `FileAttachment`-annotations exist in the document they will now be appended at the end.
This commit is contained in:
Jonas Jenwald 2023-05-21 09:54:24 +02:00
parent 65e23432cd
commit 14fd59c4d0
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
web/pdf_attachment_viewer.js
View File

@ -109,13 +109,10 @@ class PDFAttachmentViewer extends BaseTreeViewer {
this._dispatchEvent(/* attachmentsCount = */ 0);
return;
}
const names = Object.keys(attachments).sort(function (a, b) {
return a.toLowerCase().localeCompare(b.toLowerCase());
});
const fragment = document.createDocumentFragment();
let attachmentsCount = 0;
for (const name of names) {
for (const name in attachments) {
const item = attachments[name];
const content = item.content,
filename = getFilenameFromUrl(