Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't detect nw.js as node.js

Browse Source 
nw.js is chrome plus nodejs.
It will succeed everywhere chrome succeeds, but fail in many cases where nodejs succeeds (see issue 9071).
So it's safer to consider it as a browser context rather than a nodejs context.

Make travis happy again

CS

Readability + Explanation

The relevant portion of the NW.js documentation:
http://docs.nwjs.io/en/latest/For%20Users/Advanced/JavaScript%20Contexts%20in%20NW.js/#access-nodejs-and-nwjs-api-in-browser-context

Added full link to relevant doc.
This commit is contained in:
Romain Petit 2018-11-06 15:56:17 +01:00 committed by Romain Petit
parent 45758dd2d5
commit 13b0ca6b2a
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/shared/is_node.js
View File

@ -15,5 +15,9 @@
/* globals module, process */
module.exports = function isNodeJS() {
return typeof process === 'object' && process + '' === '[object process]';
// NW.js is a browser context, but copies some Node.js objects; see
// http://docs.nwjs.io/en/latest/For%20Users/Advanced/JavaScript%20Contexts%20in%20NW.js/#access-nodejs-and-nwjs-api-in-browser-context
return typeof process === 'object' &&
process + '' === '[object process]' &&
!process.versions['nw'];
};