Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #10119 from Snuffleupagus/rm-onFileAttachmentAnnotation

Browse Source 
Attempt to simplify the `fileattachmentannotation` event dispatching
This commit is contained in:
Tim van der Meij 2018-10-02 23:25:22 +02:00 committed by GitHub
commit 138324502c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/display/annotation_layer.js
View File

@ -1130,15 +1130,18 @@ class FileAttachmentAnnotationElement extends AnnotationElement {
constructor(parameters) { constructor(parameters) {
super(parameters, /* isRenderable = */ true); super(parameters, /* isRenderable = */ true);
let file = this.data.file; const { filename, content, } = this.data.file;
this.filename = getFilenameFromUrl(file.filename); this.filename = getFilenameFromUrl(filename);
this.content = file.content; this.content = content;
this.linkService.onFileAttachmentAnnotation({ if (this.linkService.eventBus) {
id: stringToPDFString(file.filename), this.linkService.eventBus.dispatch('fileattachmentannotation', {
filename: file.filename, source: this,
content: file.content, id: stringToPDFString(filename),
}); filename,
content,
});
}
} }
/** /**

5
web/interfaces.js
View File

@ -67,11 +67,6 @@ class IPDFLinkService {
*/ */
executeNamedAction(action) {} executeNamedAction(action) {}
/**
* @param {Object} params
*/
onFileAttachmentAnnotation({ id, filename, content, }) {}
/** /**
* @param {number} pageNum - page number. * @param {number} pageNum - page number.
* @param {Object} pageRef - reference to the page. * @param {Object} pageRef - reference to the page.

17
web/pdf_link_service.js
View File

@ -337,18 +337,6 @@ class PDFLinkService {
}); });
} }
/**
* @param {Object} params
*/
onFileAttachmentAnnotation({ id, filename, content, }) {
this.eventBus.dispatch('fileattachmentannotation', {
source: this,
id,
filename,
content,
});
}
/** /**
* @param {number} pageNum - page number. * @param {number} pageNum - page number.
* @param {Object} pageRef - reference to the page. * @param {Object} pageRef - reference to the page.
@ -481,11 +469,6 @@ class SimpleLinkService {
*/ */
executeNamedAction(action) {} executeNamedAction(action) {}
/**
* @param {Object} params
*/
onFileAttachmentAnnotation({ id, filename, content, }) {}
/** /**
* @param {number} pageNum - page number. * @param {number} pageNum - page number.
* @param {Object} pageRef - reference to the page. * @param {Object} pageRef - reference to the page.