Address review comments.
This commit is contained in:
parent
5e04ad5e3a
commit
0f4730c825
@ -10,14 +10,14 @@ var FontInspector = (function FontInspectorClosure() {
|
|||||||
var fontAttribute = 'data-font-name';
|
var fontAttribute = 'data-font-name';
|
||||||
function removeSelection() {
|
function removeSelection() {
|
||||||
var divs = document.querySelectorAll('div[' + fontAttribute + ']');
|
var divs = document.querySelectorAll('div[' + fontAttribute + ']');
|
||||||
for (var i = 0; i < divs.length; ++i) {
|
for (var i = 0, ii = divs.length; i < ii; ++i) {
|
||||||
var div = divs[i];
|
var div = divs[i];
|
||||||
div.className = '';
|
div.className = '';
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
function resetSelection() {
|
function resetSelection() {
|
||||||
var divs = document.querySelectorAll('div[' + fontAttribute + ']');
|
var divs = document.querySelectorAll('div[' + fontAttribute + ']');
|
||||||
for (var i = 0; i < divs.length; ++i) {
|
for (var i = 0, ii = divs.length; i < ii; ++i) {
|
||||||
var div = divs[i];
|
var div = divs[i];
|
||||||
div.className = 'debuggerHideText';
|
div.className = 'debuggerHideText';
|
||||||
}
|
}
|
||||||
@ -25,7 +25,7 @@ var FontInspector = (function FontInspectorClosure() {
|
|||||||
function selectFont(fontName, show) {
|
function selectFont(fontName, show) {
|
||||||
var divs = document.querySelectorAll('div[' + fontAttribute + '=' +
|
var divs = document.querySelectorAll('div[' + fontAttribute + '=' +
|
||||||
fontName + ']');
|
fontName + ']');
|
||||||
for (var i = 0; i < divs.length; ++i) {
|
for (var i = 0, ii = divs.length; i < ii; ++i) {
|
||||||
var div = divs[i];
|
var div = divs[i];
|
||||||
div.className = show ? 'debuggerShowText' : 'debuggerHideText';
|
div.className = show ? 'debuggerShowText' : 'debuggerHideText';
|
||||||
}
|
}
|
||||||
@ -211,6 +211,7 @@ var Stepper = (function StepperClosure() {
|
|||||||
}
|
}
|
||||||
Stepper.prototype = {
|
Stepper.prototype = {
|
||||||
init: function init(IRQueue) {
|
init: function init(IRQueue) {
|
||||||
|
// Shorter way to create element and optionally set textContent.
|
||||||
function c(tag, textContent) {
|
function c(tag, textContent) {
|
||||||
var d = document.createElement(tag);
|
var d = document.createElement(tag);
|
||||||
if (textContent)
|
if (textContent)
|
||||||
@ -219,7 +220,7 @@ var Stepper = (function StepperClosure() {
|
|||||||
}
|
}
|
||||||
var panel = this.panel;
|
var panel = this.panel;
|
||||||
this.len = IRQueue.fnArray.length;
|
this.len = IRQueue.fnArray.length;
|
||||||
var content = c('div', 'c=contine, s=step');
|
var content = c('div', 'c=continue, s=step');
|
||||||
var table = c('table');
|
var table = c('table');
|
||||||
content.appendChild(table);
|
content.appendChild(table);
|
||||||
table.cellSpacing = 0;
|
table.cellSpacing = 0;
|
||||||
|
Loading…
x
Reference in New Issue
Block a user