Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Ensure that attempting to print with disableAutoFetch set will fail gracefully (issue 11339)

Browse Source 
This patch simply restores the behaviour that existed prior to PR 7697, since I cannot imagine that that was changed other than by pure accident.
As mentioned by a comment in `BaseViewer.setDocument`: "Printing is semi-broken with auto fetch disabled.", and note that since triggering of printing is a synchronous operation there's generally no easy way to load the missing data.

https://github.com/mozilla/pdf.js/pull/7697/files#diff-529d1853ee1bba753a0fcb40ea778723L1114-L1118
This commit is contained in:
Jonas Jenwald 2019-11-19 11:58:19 +01:00
parent be02e67972
commit 0b0bf71ad0
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
web/base_viewer.js
View File

@ -181,7 +181,14 @@ class BaseViewer {
* @type {boolean} - True if all {PDFPageView} objects are initialized. * @type {boolean} - True if all {PDFPageView} objects are initialized.
*/ */
get pageViewsReady() { get pageViewsReady() {
return this._pageViewsReady; if (!this._pageViewsReady) {
return false;
}
// Prevent printing errors when 'disableAutoFetch' is set, by ensuring
// that *all* pages have in fact been completely loaded.
return this._pages.every(function(pageView) {
return !!(pageView && pageView.pdfPage);
});
} }
/** /**