From 0ac8f33e1358f67762152704bb363f9cf1febb9b Mon Sep 17 00:00:00 2001
From: Jonas Jenwald <jonas.jenwald@gmail.com>
Date: Tue, 19 Sep 2023 12:26:55 +0200
Subject: [PATCH] Ignore optional content with missing /Type-entries

In the rare situation that an optional content dictionary lacks a /Type-entry we currently throw, which may prevent e.g. Form XObjects from rendering completely.

Fixes https://bugs.ghostscript.com/show_bug.cgi?id=707147
---
 src/core/evaluator.js           | 2 +-
 test/pdfs/mupdf-707147.pdf.link | 1 +
 test/test_manifest.json         | 8 ++++++++
 3 files changed, 10 insertions(+), 1 deletion(-)
 create mode 100644 test/pdfs/mupdf-707147.pdf.link

diff --git a/src/core/evaluator.js b/src/core/evaluator.js
index 77aebfb5f..bcfe4827d 100644
--- a/src/core/evaluator.js
+++ b/src/core/evaluator.js
@@ -1581,7 +1581,7 @@ class PartialEvaluator {
       throw new FormatError("Optional content properties malformed.");
     }
 
-    const optionalContentType = optionalContent.get("Type").name;
+    const optionalContentType = optionalContent.get("Type")?.name;
     if (optionalContentType === "OCG") {
       return {
         type: optionalContentType,
diff --git a/test/pdfs/mupdf-707147.pdf.link b/test/pdfs/mupdf-707147.pdf.link
new file mode 100644
index 000000000..e2f57a637
--- /dev/null
+++ b/test/pdfs/mupdf-707147.pdf.link
@@ -0,0 +1 @@
+https://web.archive.org/web/20230919100948/https://bugs.ghostscript.com/attachment.cgi?id=24825
diff --git a/test/test_manifest.json b/test/test_manifest.json
index a401d84ef..ef5bb7701 100644
--- a/test/test_manifest.json
+++ b/test/test_manifest.json
@@ -5590,6 +5590,14 @@
        "lastPage": 1,
        "type": "text"
     },
+    {  "id": "mupdf-707147",
+       "file": "pdfs/mupdf-707147.pdf",
+       "md5": "3b6f4e142baed0585bb52c1eb79f918a",
+       "rounds": 1,
+       "link": true,
+       "lastPage": 1,
+       "type": "eq"
+    },
     {  "id": "issue5421",
        "file": "pdfs/issue5421.pdf",
        "md5": "273f6813758a2349090003c7c8a0d85e",