Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Tweak the MMType1 font detection in getFontFileType to improve font telemetry (PR 9961 follow-up)

Browse Source 
Please note that this patch does *not* affect rendering in any way, however it's relevant for font telemetry[1].

According to the specification, see https://www.adobe.com/content/dam/acom/en/devnet/acrobat/pdfs/PDF32000_2008.pdf#G8.1904956, Type1C is a valid subtype for *both* Type1 and MMType1 fonts.

---
[1] Refer to the font telemetry results in https://telemetry.mozilla.org/new-pipeline/dist.html#!cumulative=0&end_date=2018-06-25&keys=__none__!__none__!__none__&max_channel_version=nightly%252F62&measure=PDF_VIEWER_FONT_TYPES&min_channel_version=nightly%252F59&processType=*&product=Firefox&sanitize=1&sort_keys=submissions&start_date=2018-05-07&table=0&trim=1&use_submission_date=0

See also https://github.com/mozilla/pdf.js/wiki/Enumeration-Assignments-for-the-Telemetry-Histograms#pdf_viewer_font_types for help with interpreting the data.
This commit is contained in:
Jonas Jenwald 2018-08-08 12:18:37 +02:00
parent 13b98746d9
commit 06d1ff5af4
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/core/fonts.js
View File

@ -717,17 +717,15 @@ var Font = (function FontClosure() {
} else if (isType1File(file)) { } else if (isType1File(file)) {
if (composite) { if (composite) {
fileType = 'CIDFontType0'; fileType = 'CIDFontType0';
} else if (type === 'MMType1') {
fileType = 'MMType1';
} else { } else {
fileType = 'Type1'; fileType = (type === 'MMType1' ? 'MMType1' : 'Type1');
} }
} else if (isCFFFile(file)) { } else if (isCFFFile(file)) {
if (composite) { if (composite) {
fileType = 'CIDFontType0'; fileType = 'CIDFontType0';
fileSubtype = 'CIDFontType0C'; fileSubtype = 'CIDFontType0C';
} else { } else {
fileType = 'Type1'; fileType = (type === 'MMType1' ? 'MMType1' : 'Type1');
fileSubtype = 'Type1C'; fileSubtype = 'Type1C';
} }
} else { } else {