Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #16550 from Snuffleupagus/rm-RenderingCancelledException-type

Browse Source 
[api-minor] Remove the `type` from `RenderingCancelledException` (PR 16226 follow-up)
This commit is contained in:
Jonas Jenwald 2023-06-15 12:26:27 +02:00 committed by GitHub
commit 0650be4641
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/display/api.js
View File

@ -3347,7 +3347,6 @@ class InternalRenderTask {
error || error ||
new RenderingCancelledException( new RenderingCancelledException(
`Rendering cancelled, page ${this._pageIndex + 1}`, `Rendering cancelled, page ${this._pageIndex + 1}`,
"canvas",
extraDelay extraDelay
) )
); );

3
src/display/display_utils.js
View File

@ -583,9 +583,8 @@ class PageViewport {
} }
class RenderingCancelledException extends BaseException { class RenderingCancelledException extends BaseException {
constructor(msg, type, extraDelay = 0) { constructor(msg, extraDelay = 0) {
super(msg, "RenderingCancelledException"); super(msg, "RenderingCancelledException");
this.type = type;
this.extraDelay = extraDelay; this.extraDelay = extraDelay;
} }
} }

1
test/unit/api_spec.js
View File

@ -3075,7 +3075,6 @@ Caron Broadcasting, Inc., an Ohio corporation (“Lessee”).`)
} catch (reason) { } catch (reason) {
expect(reason instanceof RenderingCancelledException).toEqual(true); expect(reason instanceof RenderingCancelledException).toEqual(true);
expect(reason.message).toEqual("Rendering cancelled, page 1"); expect(reason.message).toEqual("Rendering cancelled, page 1");
expect(reason.type).toEqual("canvas");
expect(reason.extraDelay).toEqual(0); expect(reason.extraDelay).toEqual(0);
} }