Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Enable the --report-unused-disable-directives ESLint command line option

Browse Source 
This option was added in [version `4.8.0` of ESLint](https://github.com/eslint/eslint/releases/tag/v4.8.0), which is already listed as the minimum version in our `package.json` file; please refer to https://eslint.org/docs/user-guide/command-line-interface#--report-unused-disable-directives for additional details.

Despite the caveat listed in the link above, I still think that using this option makes sense since it will help ensure that no longer necessary disable statements are removed.
This commit is contained in:
Jonas Jenwald 2017-10-15 13:38:53 +02:00
parent 5ad945f462
commit 04b46831c1
3 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gulpfile.js
View File

@ -1160,7 +1160,8 @@ gulp.task('lint', function (done) {
console.log('### Linting JS files'); console.log('### Linting JS files');
// Ensure that we lint the Firefox specific *.jsm files too. // Ensure that we lint the Firefox specific *.jsm files too.
var options = ['node_modules/eslint/bin/eslint', '--ext', '.js,.jsm', '.']; var options = ['node_modules/eslint/bin/eslint', '--ext', '.js,.jsm', '.',
'--report-unused-disable-directives'];
var esLintProcess = spawn('node', options, { stdio: 'inherit', }); var esLintProcess = spawn('node', options, { stdio: 'inherit', });
esLintProcess.on('close', function (code) { esLintProcess.on('close', function (code) {
if (code !== 0) { if (code !== 0) {

1
src/doc_helper.js
View File

@ -12,7 +12,6 @@
* See the License for the specific language governing permissions and * See the License for the specific language governing permissions and
* limitations under the License. * limitations under the License.
*/ */
/* eslint-disable strict */
/* /*
NOTE: This file is created as a helper to assist with JSDoc html files. NOTE: This file is created as a helper to assist with JSDoc html files.

1
src/pdf.worker.entry.js
View File

@ -12,7 +12,6 @@
* See the License for the specific language governing permissions and * See the License for the specific language governing permissions and
* limitations under the License. * limitations under the License.
*/ */
/* eslint-disable strict */
(typeof window !== 'undefined' ? window : {}).pdfjsDistBuildPdfWorker = (typeof window !== 'undefined' ? window : {}).pdfjsDistBuildPdfWorker =
require('./pdf.worker.js'); require('./pdf.worker.js');