Merge pull request #12801 from Snuffleupagus/FirefoxCom-document-listener

Modernize the `FirefoxCom.request` method
This commit is contained in:
Tim van der Meij 2021-01-01 14:03:56 +01:00 committed by GitHub
commit 04321546ce
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -48,7 +48,8 @@ const FirefoxCom = (function FirefoxComClosure() {
}); });
request.dispatchEvent(sender); request.dispatchEvent(sender);
const response = sender.detail.response; const response = sender.detail.response;
document.documentElement.removeChild(request); request.remove();
return response; return response;
}, },
@ -63,15 +64,16 @@ const FirefoxCom = (function FirefoxComClosure() {
request(action, data, callback) { request(action, data, callback) {
const request = document.createTextNode(""); const request = document.createTextNode("");
if (callback) { if (callback) {
document.addEventListener("pdf.js.response", function listener(event) { request.addEventListener(
const node = event.target; "pdf.js.response",
const response = event.detail.response; event => {
const response = event.detail.response;
event.target.remove();
document.documentElement.removeChild(node); callback(response);
},
document.removeEventListener("pdf.js.response", listener); { once: true }
return callback(response); );
});
} }
document.documentElement.appendChild(request); document.documentElement.appendChild(request);