Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Simplify spread-mode handling for the PAGE scroll-mode

Browse Source 
The spread-mode code in `BaseViewer.#ensurePageViewVisible`-method was initially copied from the `BaseViewer._updateSpreadMode`-method, which means that it's slightly more complicated than actually necessary.
In particular, in the PAGE scroll-mode there can only be *one* spread active at a time and we thus don't need to handle insertion of multiple spread-divs.
This commit is contained in:
Jonas Jenwald 2022-04-17 10:53:34 +02:00
parent b73a6cc213
commit 03ec7a22f2
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
web/base_viewer.js
View File

@ -920,24 +920,19 @@ class BaseViewer {
} }
// Finally, append the new pages to the viewer and apply the spreadMode. // Finally, append the new pages to the viewer and apply the spreadMode.
let spread = null; const spread = document.createElement("div");
spread.className = "spread";
for (const i of pageIndexSet) { for (const i of pageIndexSet) {
const pageView = this._pages[i]; const pageView = this._pages[i];
if (!pageView) { if (!pageView) {
continue; continue;
} }
if (spread === null) {
spread = document.createElement("div");
spread.className = "spread";
viewer.appendChild(spread);
} else if (i % 2 === parity) {
spread = spread.cloneNode(false);
viewer.appendChild(spread);
}
spread.appendChild(pageView.div); spread.appendChild(pageView.div);
state.pages.push(pageView); state.pages.push(pageView);
} }
viewer.appendChild(spread);
} }
state.scrollDown = pageNumber >= state.previousPageNumber; state.scrollDown = pageNumber >= state.previousPageNumber;