From 01c1d87171cd7d5a72edaedeb86360242d211ddb Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Wed, 9 Sep 2020 13:29:44 +0200 Subject: [PATCH] Remove CSS variables feature-testing from `PDFSidebarResizer` CSS variables are now supported in all reasonably modern browsers, according to: - https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties#Browser_compatibility - https://caniuse.com/css-variables --- web/pdf_sidebar_resizer.js | 25 +------------------------ web/viewer.html | 2 +- 2 files changed, 2 insertions(+), 25 deletions(-) diff --git a/web/pdf_sidebar_resizer.js b/web/pdf_sidebar_resizer.js index b3f5b178c..e69c55bf9 100644 --- a/web/pdf_sidebar_resizer.js +++ b/web/pdf_sidebar_resizer.js @@ -34,7 +34,6 @@ class PDFSidebarResizer { * @param {IL10n} l10n - Localization service. */ constructor(options, eventBus, l10n = NullL10n) { - this.enabled = false; this.isRTL = false; this.sidebarOpen = false; this.doc = document.documentElement; @@ -45,24 +44,8 @@ class PDFSidebarResizer { this.outerContainer = options.outerContainer; this.resizer = options.resizer; this.eventBus = eventBus; - this.l10n = l10n; - if ( - (typeof PDFJSDev === "undefined" || !PDFJSDev.test("MOZCENTRAL")) && - (typeof CSS === "undefined" || - typeof CSS.supports !== "function" || - !CSS.supports(SIDEBAR_WIDTH_VAR, `calc(-1 * ${SIDEBAR_MIN_WIDTH}px)`)) - ) { - console.warn( - "PDFSidebarResizer: " + - "The browser does not support resizing of the sidebar." - ); - return; - } - this.enabled = true; - this.resizer.classList.remove("hidden"); // Show the resizer DOM element. - - this.l10n.getDirection().then(dir => { + l10n.getDirection().then(dir => { this.isRTL = dir === "rtl"; }); this._addEventListeners(); @@ -83,9 +66,6 @@ class PDFSidebarResizer { * returns {boolean} Indicating if the sidebar width was updated. */ _updateWidth(width = 0) { - if (!this.enabled) { - return false; - } // Prevent the sidebar from becoming too narrow, or from occupying more // than half of the available viewer width. const maxWidth = Math.floor(this.outerContainerWidth / 2); @@ -134,9 +114,6 @@ class PDFSidebarResizer { * @private */ _addEventListeners() { - if (!this.enabled) { - return; - } const _boundEvents = this._boundEvents; _boundEvents.mouseMove = this._mouseMove.bind(this); _boundEvents.mouseUp = this._mouseUp.bind(this); diff --git a/web/viewer.html b/web/viewer.html index 1ae684876..0bef5178b 100644 --- a/web/viewer.html +++ b/web/viewer.html @@ -101,7 +101,7 @@ See https://github.com/adobe-type-tools/cmap-resources - +