Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Re-name the XFAFactory.numberPages getter to XFAFactory.numPages for consistency

Browse Source 
All other similar getters are called `numPages` throughout the code-base, and improved consistency should always be a good thing.
This commit is contained in:
Jonas Jenwald 2021-10-16 12:35:12 +02:00
parent 0e5348180e
commit 0041230072
3 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/document.js
View File

@ -787,7 +787,7 @@ class PDFDocument {
get numPages() { get numPages() {
let num = 0; let num = 0;
if (this.xfaFactory) { if (this.xfaFactory) {
num = this.xfaFactory.numberPages; num = this.xfaFactory.numPages;
} else if (this.linearization) { } else if (this.linearization) {
num = this.linearization.numPages; num = this.linearization.numPages;
} else { } else {

2
src/core/xfa/factory.js
View File

@ -54,7 +54,7 @@ class XFAFactory {
return this.dims[pageIndex]; return this.dims[pageIndex];
} }
get numberPages() { get numPages() {
if (!this.pages) { if (!this.pages) {
this._createPages(); this._createPages();
} }

28
test/unit/xfa_tohtml_spec.js
View File

@ -86,7 +86,7 @@ describe("XFAFactory", function () {
const factory = new XFAFactory({ "xdp:xdp": xml }); const factory = new XFAFactory({ "xdp:xdp": xml });
factory.setFonts([]); factory.setFonts([]);
expect(factory.numberPages).toEqual(2); expect(factory.numPages).toEqual(2);
const pages = factory.getPages(); const pages = factory.getPages();
const page1 = pages.children[0]; const page1 = pages.children[0];
@ -174,7 +174,7 @@ describe("XFAFactory", function () {
`; `;
const factory = new XFAFactory({ "xdp:xdp": xml }); const factory = new XFAFactory({ "xdp:xdp": xml });
expect(factory.numberPages).toEqual(1); expect(factory.numPages).toEqual(1);
const pages = factory.getPages(); const pages = factory.getPages();
const field = searchHtmlNode(pages, "name", "img"); const field = searchHtmlNode(pages, "name", "img");
@ -208,7 +208,7 @@ describe("XFAFactory", function () {
`; `;
const factory = new XFAFactory({ "xdp:xdp": xml }); const factory = new XFAFactory({ "xdp:xdp": xml });
expect(factory.numberPages).toEqual(1); expect(factory.numPages).toEqual(1);
const pages = factory.getPages(); const pages = factory.getPages();
const page1 = pages.children[0]; const page1 = pages.children[0];
@ -263,7 +263,7 @@ describe("XFAFactory", function () {
const factory = new XFAFactory({ "xdp:xdp": xml }); const factory = new XFAFactory({ "xdp:xdp": xml });
factory.setFonts([]); factory.setFonts([]);
expect(factory.numberPages).toEqual(1); expect(factory.numPages).toEqual(1);
const pages = factory.getPages(); const pages = factory.getPages();
const table = searchHtmlNode( const table = searchHtmlNode(
@ -336,7 +336,7 @@ describe("XFAFactory", function () {
`; `;
const factory = new XFAFactory({ "xdp:xdp": xml }); const factory = new XFAFactory({ "xdp:xdp": xml });
expect(factory.numberPages).toEqual(1); expect(factory.numPages).toEqual(1);
const pages = factory.getPages(); const pages = factory.getPages();
const field = searchHtmlNode(pages, "name", "input"); const field = searchHtmlNode(pages, "name", "input");
@ -378,7 +378,7 @@ describe("XFAFactory", function () {
`; `;
const factory = new XFAFactory({ "xdp:xdp": xml }); const factory = new XFAFactory({ "xdp:xdp": xml });
expect(factory.numberPages).toEqual(1); expect(factory.numPages).toEqual(1);
const pages = factory.getPages(); const pages = factory.getPages();
const field = searchHtmlNode(pages, "name", "input"); const field = searchHtmlNode(pages, "name", "input");
@ -420,7 +420,7 @@ describe("XFAFactory", function () {
`; `;
const factory = new XFAFactory({ "xdp:xdp": xml }); const factory = new XFAFactory({ "xdp:xdp": xml });
expect(factory.numberPages).toEqual(1); expect(factory.numPages).toEqual(1);
const pages = factory.getPages(); const pages = factory.getPages();
const field = searchHtmlNode(pages, "name", "input"); const field = searchHtmlNode(pages, "name", "input");
@ -463,7 +463,7 @@ describe("XFAFactory", function () {
`; `;
const factory = new XFAFactory({ "xdp:xdp": xml }); const factory = new XFAFactory({ "xdp:xdp": xml });
expect(factory.numberPages).toEqual(1); expect(factory.numPages).toEqual(1);
const pages = factory.getPages(); const pages = factory.getPages();
const field1 = searchHtmlNode(pages, "name", "input"); const field1 = searchHtmlNode(pages, "name", "input");
@ -517,7 +517,7 @@ describe("XFAFactory", function () {
`; `;
const factory = new XFAFactory({ "xdp:xdp": xml }); const factory = new XFAFactory({ "xdp:xdp": xml });
expect(factory.numberPages).toEqual(1); expect(factory.numPages).toEqual(1);
const pages = factory.getPages(); const pages = factory.getPages();
const field1 = searchHtmlNode(pages, "name", "input"); const field1 = searchHtmlNode(pages, "name", "input");
@ -560,7 +560,7 @@ describe("XFAFactory", function () {
// A valid, and complete, URL. // A valid, and complete, URL.
factory = new XFAFactory({ "xdp:xdp": getXml("https://www.example.com/") }); factory = new XFAFactory({ "xdp:xdp": getXml("https://www.example.com/") });
expect(factory.numberPages).toEqual(1); expect(factory.numPages).toEqual(1);
pages = factory.getPages(); pages = factory.getPages();
a = searchHtmlNode(pages, "name", "a"); a = searchHtmlNode(pages, "name", "a");
expect(a.value).toEqual("https://www.example.com/"); expect(a.value).toEqual("https://www.example.com/");
@ -568,7 +568,7 @@ describe("XFAFactory", function () {
// A valid, but incomplete, URL. // A valid, but incomplete, URL.
factory = new XFAFactory({ "xdp:xdp": getXml("www.example.com/") }); factory = new XFAFactory({ "xdp:xdp": getXml("www.example.com/") });
expect(factory.numberPages).toEqual(1); expect(factory.numPages).toEqual(1);
pages = factory.getPages(); pages = factory.getPages();
a = searchHtmlNode(pages, "name", "a"); a = searchHtmlNode(pages, "name", "a");
expect(a.value).toEqual("www.example.com/"); expect(a.value).toEqual("www.example.com/");
@ -576,7 +576,7 @@ describe("XFAFactory", function () {
// A valid email-address. // A valid email-address.
factory = new XFAFactory({ "xdp:xdp": getXml("mailto:test@example.com") }); factory = new XFAFactory({ "xdp:xdp": getXml("mailto:test@example.com") });
expect(factory.numberPages).toEqual(1); expect(factory.numPages).toEqual(1);
pages = factory.getPages(); pages = factory.getPages();
a = searchHtmlNode(pages, "name", "a"); a = searchHtmlNode(pages, "name", "a");
expect(a.value).toEqual("mailto:test@example.com"); expect(a.value).toEqual("mailto:test@example.com");
@ -584,7 +584,7 @@ describe("XFAFactory", function () {
// Not a valid URL. // Not a valid URL.
factory = new XFAFactory({ "xdp:xdp": getXml("qwerty/") }); factory = new XFAFactory({ "xdp:xdp": getXml("qwerty/") });
expect(factory.numberPages).toEqual(1); expect(factory.numPages).toEqual(1);
pages = factory.getPages(); pages = factory.getPages();
a = searchHtmlNode(pages, "name", "a"); a = searchHtmlNode(pages, "name", "a");
expect(a.value).toEqual("qwerty/"); expect(a.value).toEqual("qwerty/");
@ -635,7 +635,7 @@ describe("XFAFactory", function () {
`; `;
const factory = new XFAFactory({ "xdp:xdp": xml }); const factory = new XFAFactory({ "xdp:xdp": xml });
expect(factory.numberPages).toEqual(1); expect(factory.numPages).toEqual(1);
const pages = factory.getPages(); const pages = factory.getPages();
let a = searchHtmlNode(pages, "name", "a"); let a = searchHtmlNode(pages, "name", "a");