pdf.js/.stylelintrc

{
  "plugins": [
    "stylelint-prettier"
  ],

  "rules": {
    "prettier/prettier": true,

    "block-no-empty": true,
    "declaration-block-no-redundant-longhand-properties": true,
    "declaration-property-value-disallowed-list": {
      "float": ["inline-start", "inline-end"]
    },
    "length-zero-no-unit": [true, {
      ignore: ["custom-properties"]
    }],
    "selector-pseudo-element-colon-notation": "double",
    "shorthand-property-no-redundant-values": true,
  },
}
Add (basic) support for Stylelint, to allow linting of CSS files This is similar to the existing linting for JavaScript files, but covers CSS files instead. While there's a lot of rules that could potentially be used, the main advantage of using Stylelint is that it has Prettier integration which means that we can automatically enforce a consistent style for our CSS files as well. As a proof of concept, this patch is purposely limited to: - Adding a simple rule, here `block-no-empty` is chosen; see https://stylelint.io/user-guide/rules/block-no-empty - Adding Prettier integration, to unify the style of our CSS files. Please find additional information at https://stylelint.io/ 2020-08-29 23:35:27 +09:00			`{`
			`"plugins": [`
			`"stylelint-prettier"`
			`],`

			`"rules": {`
Update Stylelint to version 15 Notably this obsoletes the `stylelint-config-prettier` package; please see https://github.com/stylelint/stylelint/blob/main/docs/migration-guide/to-15.md for additional details. 2023-02-11 22:41:32 +09:00			`"prettier/prettier": true,`

Add (basic) support for Stylelint, to allow linting of CSS files This is similar to the existing linting for JavaScript files, but covers CSS files instead. While there's a lot of rules that could potentially be used, the main advantage of using Stylelint is that it has Prettier integration which means that we can automatically enforce a consistent style for our CSS files as well. As a proof of concept, this patch is purposely limited to: - Adding a simple rule, here `block-no-empty` is chosen; see https://stylelint.io/user-guide/rules/block-no-empty - Adding Prettier integration, to unify the style of our CSS files. Please find additional information at https://stylelint.io/ 2020-08-29 23:35:27 +09:00			`"block-no-empty": true,`
Enable the `declaration-block-no-redundant-longhand-properties` Stylelint rule Note that these changes were done automatically, using `gulp lint --fix`. This rule will help avoid unnecessary repetition in the CSS; please see https://stylelint.io/user-guide/rules/declaration-block-no-redundant-longhand-properties/ 2023-03-25 18:04:29 +09:00			`"declaration-block-no-redundant-longhand-properties": true,`
[Firefox] Use `float: inline-start/inline-end` directly in MOZCENTRAL builds (PR 15968 follow-up) Currently `float: inline-start/inline-end` is only supported in Firefox, see https://developer.mozilla.org/en-US/docs/Web/CSS/float#browser_compatibility, and in order to support other browsers we're thus forced to jump through some hoops. This leads to slightly less nice code in the built-in Firefox PDF Viewer, and this patch attempts to improve the current situation: - Use Stylelint to forbid direct use of `float: inline-start/inline-end` in the CSS files, to prevent future bugs in the general PDF.js viewer. - Do a build-time replacement, only in MOZCENTRAL builds, to replace the CSS-variables with raw `float: inline-start/inline-end` instances. 2023-04-09 19:38:49 +09:00			`"declaration-property-value-disallowed-list": {`
			`"float": ["inline-start", "inline-end"]`
			`},`
Enable the Stylelint `length-zero-no-unit` rule Note that these changes were done automatically, using `gulp lint --fix`. With this rule, we'll thus enforce a consistent formatting of zero-lengths in our CSS files. Please find additional details about the Stylelint rule at https://stylelint.io/user-guide/rules/length-zero-no-unit 2021-01-10 22:02:38 +09:00			`"length-zero-no-unit": [true, {`
			`ignore: ["custom-properties"]`
			`}],`
Enforce double-colon notation for CSS pseudo-elements These changes are part of https://phabricator.services.mozilla.com/D170496, and thanks to a Stylelint rule we can both enforce and fix this automatically; see also https://stylelint.io/user-guide/rules/selector-pseudo-element-colon-notation/ 2023-04-18 22:46:51 +09:00			`"selector-pseudo-element-colon-notation": "double",`
Enable the Stylelint `shorthand-property-no-redundant-values` rule Note that these changes were done automatically, using `gulp lint --fix`; this rule will help avoid unnecessary repetition in the CSS. Please find additional details about the Stylelint rule at https://stylelint.io/user-guide/rules/shorthand-property-no-redundant-values 2021-01-22 22:36:02 +09:00			`"shorthand-property-no-redundant-values": true,`
Add (basic) support for Stylelint, to allow linting of CSS files This is similar to the existing linting for JavaScript files, but covers CSS files instead. While there's a lot of rules that could potentially be used, the main advantage of using Stylelint is that it has Prettier integration which means that we can automatically enforce a consistent style for our CSS files as well. As a proof of concept, this patch is purposely limited to: - Adding a simple rule, here `block-no-empty` is chosen; see https://stylelint.io/user-guide/rules/block-no-empty - Adding Prettier integration, to unify the style of our CSS files. Please find additional information at https://stylelint.io/ 2020-08-29 23:35:27 +09:00			`},`
			`}`