2016-05-23 22:50:07 +09:00
|
|
|
/*
|
|
|
|
Copyright 2016 Mozilla Foundation
|
|
|
|
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
you may not use this file except in compliance with the License.
|
|
|
|
You may obtain a copy of the License at
|
|
|
|
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
See the License for the specific language governing permissions and
|
|
|
|
limitations under the License.
|
|
|
|
*/
|
Switch to using ESLint, instead of JSHint, for linting
*Please note that most of the necessary code adjustments were made in PR 7890.*
ESLint has a number of advantageous properties, compared to JSHint. Among those are:
- The ability to find subtle bugs, thanks to more rules (e.g. PR 7881).
- Much more customizable in general, and many rules allow fine-tuned behaviour rather than the just the on/off rules in JSHint.
- Many more rules that can help developers avoid bugs, and a lot of rules that can be used to enforce a consistent coding style. The latter should be particularily useful for new contributors (and reduce the amount of stylistic review comments necessary).
- The ability to easily specify exactly what rules to use/not to use, as opposed to JSHint which has a default set. *Note:* in future JSHint version some of the rules we depend on will be removed, according to warnings in http://jshint.com/docs/options/, so we wouldn't be able to update without losing lint coverage.
- More easily disable one, or more, rules temporarily. In JSHint this requires using a numeric code, which isn't very user friendly, whereas in ESLint the rule name is simply used instead.
By default there's no rules enabled in ESLint, but there are some default rule sets available. However, to prevent linting failures if we update ESLint in the future, it seemed easier to just explicitly specify what rules we want.
Obviously this makes the ESLint config file somewhat bigger than the old JSHint config file, but given how rarely that one has been updated over the years I don't think that matters too much.
I've tried, to the best of my ability, to ensure that we enable the same rules for ESLint that we had for JSHint. Furthermore, I've also enabled a number of rules that seemed to make sense, both to catch possible errors *and* various style guide violations.
Despite the ESLint README claiming that it's slower that JSHint, https://github.com/eslint/eslint#how-does-eslint-performance-compare-to-jshint, locally this patch actually reduces the runtime for `gulp` lint (by approximately 20-25%).
A couple of stylistic rules that would have been nice to enable, but where our code currently differs to much to make it feasible:
- `comma-dangle`, controls trailing commas in Objects and Arrays (among others).
- `object-curly-spacing`, controls spacing inside of Objects.
- `spaced-comment`, used to enforce spaces after `//` and `/*. (This is made difficult by the fact that there's still some usage of the old preprocessor left.)
Rules that I indend to look into possibly enabling in follow-ups, if it seems to make sense: `no-else-return`, `no-lonely-if`, `brace-style` with the `allowSingleLine` parameter removed.
Useful links:
- http://eslint.org/docs/user-guide/configuring
- http://eslint.org/docs/rules/
2016-12-15 23:52:29 +09:00
|
|
|
/* eslint strict: ["error", "function"] */
|
2016-05-23 22:50:07 +09:00
|
|
|
|
|
|
|
(function() {
|
|
|
|
'use strict';
|
|
|
|
var storageLocal = chrome.storage.local;
|
|
|
|
var storageSync = chrome.storage.sync;
|
|
|
|
|
|
|
|
if (!storageSync) {
|
|
|
|
// No sync storage area - nothing to migrate to.
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
getStorageNames(function(storageKeys) {
|
|
|
|
storageLocal.get(storageKeys, function(values) {
|
|
|
|
if (!values || !Object.keys(values).length) {
|
|
|
|
// No local storage - nothing to migrate.
|
2017-07-15 08:50:15 +09:00
|
|
|
// ... except possibly for a renamed preference name.
|
|
|
|
migrateRenamedStorage();
|
2016-05-23 22:50:07 +09:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
migrateToSyncStorage(values);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
function getStorageNames(callback) {
|
|
|
|
var x = new XMLHttpRequest();
|
|
|
|
var schema_location = chrome.runtime.getManifest().storage.managed_schema;
|
|
|
|
x.open('get', chrome.runtime.getURL(schema_location));
|
|
|
|
x.onload = function() {
|
|
|
|
var storageKeys = Object.keys(x.response.properties);
|
|
|
|
callback(storageKeys);
|
|
|
|
};
|
|
|
|
x.responseType = 'json';
|
|
|
|
x.send();
|
|
|
|
}
|
|
|
|
|
|
|
|
// Save |values| to storage.sync and delete the values with that key from
|
|
|
|
// storage.local.
|
|
|
|
function migrateToSyncStorage(values) {
|
|
|
|
storageSync.set(values, function() {
|
|
|
|
if (chrome.runtime.lastError) {
|
|
|
|
console.error('Failed to migrate settings due to an error: ' +
|
|
|
|
chrome.runtime.lastError.message);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
// Migration successful. Delete local settings.
|
|
|
|
storageLocal.remove(Object.keys(values), function() {
|
|
|
|
// In theory remove() could fail (e.g. if the browser's storage
|
|
|
|
// backend is corrupt), but since storageSync.set succeeded, consider
|
|
|
|
// the migration successful.
|
|
|
|
console.log(
|
|
|
|
'Successfully migrated preferences from local to sync storage.');
|
2017-07-15 08:50:15 +09:00
|
|
|
migrateRenamedStorage();
|
2016-05-23 22:50:07 +09:00
|
|
|
});
|
|
|
|
});
|
|
|
|
}
|
2017-07-15 08:50:15 +09:00
|
|
|
|
|
|
|
// TODO: Remove this migration code somewhere in the future, when most users
|
|
|
|
// have had their chance of migrating to the new preference format.
|
|
|
|
// Note: We cannot modify managed preferences, so the migration logic is
|
|
|
|
// duplicated in web/chromecom.js too.
|
|
|
|
function migrateRenamedStorage() {
|
|
|
|
storageSync.get([
|
|
|
|
'enableHandToolOnLoad',
|
|
|
|
'cursorToolOnLoad',
|
[CRX] Make textLayerMode pref visible and add migration logic
In a1cfa5f4d7c8fcf55e9f3b51a23885dca8782915, the textLayerMode
preference was introduced, to replace the disableTextLayer and
enhanceTextSelection preferences.
As a result, the text selection preference was no longer visible
in Chrome (because preferences are only rendered by default for
boolean preferences, not for enumerations).
This commit adds the necessary bits to
extensions/chromium/options/options.{html,js}
so that the textLayerMode preference can be changed again.
Also, migration logic has been added to move over preferences
from the old to the new names:
- In web/chromecom.js, the logic is added to translate
preferences that were set by an administrator (it is read-only,
so this layer is unavoidable).
- In extensions/chromium/options/migration.js, similar logic is
added, except in this case the preference storage is writable,
so this migration logic happens only once.
The "enhanced text selection" mode is still experimental, so it
has been marked as experimental to signal that there may be bugs.
The list of tasks that block promotion to stable is at #7584.
2018-02-17 02:02:05 +09:00
|
|
|
'disableTextLayer',
|
|
|
|
'enhanceTextSelection',
|
|
|
|
'textLayerMode',
|
2019-02-02 18:08:45 +09:00
|
|
|
'showPreviousViewOnLoad',
|
|
|
|
'disablePageMode',
|
|
|
|
'viewOnLoad',
|
2017-07-15 08:50:15 +09:00
|
|
|
], function(items) {
|
|
|
|
// Migration code for https://github.com/mozilla/pdf.js/pull/7635.
|
|
|
|
if (typeof items.enableHandToolOnLoad === 'boolean') {
|
|
|
|
if (items.enableHandToolOnLoad) {
|
|
|
|
storageSync.set({
|
|
|
|
cursorToolOnLoad: 1,
|
|
|
|
}, function() {
|
|
|
|
if (!chrome.runtime.lastError) {
|
|
|
|
storageSync.remove('enableHandToolOnLoad');
|
|
|
|
}
|
|
|
|
});
|
|
|
|
} else {
|
|
|
|
storageSync.remove('enableHandToolOnLoad');
|
|
|
|
}
|
|
|
|
}
|
[CRX] Make textLayerMode pref visible and add migration logic
In a1cfa5f4d7c8fcf55e9f3b51a23885dca8782915, the textLayerMode
preference was introduced, to replace the disableTextLayer and
enhanceTextSelection preferences.
As a result, the text selection preference was no longer visible
in Chrome (because preferences are only rendered by default for
boolean preferences, not for enumerations).
This commit adds the necessary bits to
extensions/chromium/options/options.{html,js}
so that the textLayerMode preference can be changed again.
Also, migration logic has been added to move over preferences
from the old to the new names:
- In web/chromecom.js, the logic is added to translate
preferences that were set by an administrator (it is read-only,
so this layer is unavoidable).
- In extensions/chromium/options/migration.js, similar logic is
added, except in this case the preference storage is writable,
so this migration logic happens only once.
The "enhanced text selection" mode is still experimental, so it
has been marked as experimental to signal that there may be bugs.
The list of tasks that block promotion to stable is at #7584.
2018-02-17 02:02:05 +09:00
|
|
|
// Migration code for https://github.com/mozilla/pdf.js/pull/9479.
|
|
|
|
if (typeof items.disableTextLayer === 'boolean') {
|
|
|
|
var textLayerMode = items.disableTextLayer ? 0 :
|
|
|
|
items.enhanceTextSelection ? 2 : 1;
|
|
|
|
if (textLayerMode !== 1) {
|
|
|
|
// Overwrite if computed textLayerMode is not the default value (1).
|
|
|
|
storageSync.set({
|
|
|
|
textLayerMode: textLayerMode,
|
|
|
|
}, function() {
|
|
|
|
if (!chrome.runtime.lastError) {
|
|
|
|
storageSync.remove(['disableTextLayer', 'enhanceTextSelection']);
|
|
|
|
}
|
|
|
|
});
|
|
|
|
} else {
|
|
|
|
storageSync.remove(['disableTextLayer', 'enhanceTextSelection']);
|
|
|
|
}
|
|
|
|
}
|
2019-02-02 18:08:45 +09:00
|
|
|
// Migration code for https://github.com/mozilla/pdf.js/pull/10502.
|
|
|
|
if (typeof items.showPreviousViewOnLoad === 'boolean') {
|
|
|
|
if (!items.showPreviousViewOnLoad) {
|
|
|
|
storageSync.set({
|
|
|
|
viewOnLoad: 1,
|
|
|
|
}, function() {
|
|
|
|
if (!chrome.runtime.lastError) {
|
|
|
|
storageSync.remove(['showPreviousViewOnLoad', 'disablePageMode']);
|
|
|
|
}
|
|
|
|
});
|
|
|
|
} else {
|
|
|
|
storageSync.remove(['showPreviousViewOnLoad', 'disablePageMode']);
|
|
|
|
}
|
|
|
|
}
|
2017-07-15 08:50:15 +09:00
|
|
|
});
|
|
|
|
}
|
2016-05-23 22:50:07 +09:00
|
|
|
})();
|