pdf.js/web/.eslintrc

{
  "extends": [
    "../.eslintrc"
  ],

  "rules": {
    // Plugins
    "import/no-unresolved": ["error", { "ignore": ["pdfjs-lib"]}],

    // Stylistic Issues
    "no-nested-ternary": "error",

    // ECMAScript 6
    "no-var": "error",
    "prefer-const": "error",
  },
}
Enable the `no-var` ESLint rule in the `/web` folder https://eslint.org/docs/rules/no-var Please note that two files were excluded: 1. `web/debugger.js`, since there's code in other files that currently depend on the global availability of code in `web/debugger.js`. Furthermore, since that file isn't used in production, doing a ES6 conversion probably isn't a priority. 2. `web/grab_to_pan.js`, since that file could be considered to be "external" code. We have made smaller changes to that file over the years, however doing a full ES6 `class` conversion might be a step too far!? 2017-11-04 21:50:58 +09:00			`{`
			`"extends": [`
Fix badly formatted .eslintrc 2018-11-23 21:49:58 +09:00			`"../.eslintrc"`
Enable the `no-var` ESLint rule in the `/web` folder https://eslint.org/docs/rules/no-var Please note that two files were excluded: 1. `web/debugger.js`, since there's code in other files that currently depend on the global availability of code in `web/debugger.js`. Furthermore, since that file isn't used in production, doing a ES6 conversion probably isn't a priority. 2. `web/grab_to_pan.js`, since that file could be considered to be "external" code. We have made smaller changes to that file over the years, however doing a full ES6 `class` conversion might be a step too far!? 2017-11-04 21:50:58 +09:00			`],`

			`"rules": {`
Enable eslint-plugin-import to prevent unresolved paths 2018-11-23 21:50:28 +09:00			`// Plugins`
			`"import/no-unresolved": ["error", { "ignore": ["pdfjs-lib"]}],`

Enable the `no-nested-ternary` ESLint rule in the `web/` directory This rule is already enabled in mozilla-central, and helps avoid some confusing formatting[1], see https://searchfox.org/mozilla-central/rev/a92ed79b0bc746159fc31af1586adbfa9e45e264/tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js#209-210 Since some cases may not be aren't entirely straightforward to convert, and some we probably don't want to change either[2], this patch is limited to the `web/` directory as a proof-of-concept. Please find additional details about the ESLint rule at https://eslint.org/docs/rules/no-nested-ternary --- [1] One example with three ternary statements: https://github.com/mozilla/pdf.js/blob/93aa613db7a874e6ed964f394241605d5586c142/src/core/fonts.js#L2623-L2630 [2] One example that should be whitelisted: https://github.com/mozilla/pdf.js/blob/93aa613db7a874e6ed964f394241605d5586c142/src/core/jbig2.js#L82-L92 2020-01-08 19:56:10 +09:00			`// Stylistic Issues`
			`"no-nested-ternary": "error",`

Enable the `no-var` ESLint rule in the `/web` folder https://eslint.org/docs/rules/no-var Please note that two files were excluded: 1. `web/debugger.js`, since there's code in other files that currently depend on the global availability of code in `web/debugger.js`. Furthermore, since that file isn't used in production, doing a ES6 conversion probably isn't a priority. 2. `web/grab_to_pan.js`, since that file could be considered to be "external" code. We have made smaller changes to that file over the years, however doing a full ES6 `class` conversion might be a step too far!? 2017-11-04 21:50:58 +09:00			`// ECMAScript 6`
			`"no-var": "error",`
Enable the ESLint `prefer-const` rule in the `web/` directory Please find additional details about the ESLint rule at https://eslint.org/docs/rules/prefer-const Note that this patch is generated automatically, by using the ESLint `--fix` argument, and will thus require some additional clean-up (which is done separately). 2019-12-27 08:22:32 +09:00			`"prefer-const": "error",`
Enable the `no-var` ESLint rule in the `/web` folder https://eslint.org/docs/rules/no-var Please note that two files were excluded: 1. `web/debugger.js`, since there's code in other files that currently depend on the global availability of code in `web/debugger.js`. Furthermore, since that file isn't used in production, doing a ES6 conversion probably isn't a priority. 2. `web/grab_to_pan.js`, since that file could be considered to be "external" code. We have made smaller changes to that file over the years, however doing a full ES6 `class` conversion might be a step too far!? 2017-11-04 21:50:58 +09:00			`},`
			`}`