2023-06-22 22:16:25 +09:00
|
|
|
/* Copyright 2023 Mozilla Foundation
|
|
|
|
*
|
|
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
* you may not use this file except in compliance with the License.
|
|
|
|
* You may obtain a copy of the License at
|
|
|
|
*
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
*
|
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
* See the License for the specific language governing permissions and
|
|
|
|
* limitations under the License.
|
|
|
|
*/
|
|
|
|
|
|
|
|
import {
|
|
|
|
AbortException,
|
|
|
|
AnnotationEditorParamsType,
|
|
|
|
AnnotationEditorType,
|
|
|
|
AnnotationMode,
|
|
|
|
CMapCompressionType,
|
|
|
|
createValidAbsoluteUrl,
|
|
|
|
FeatureTest,
|
|
|
|
ImageKind,
|
|
|
|
InvalidPDFException,
|
2023-09-30 18:56:27 +09:00
|
|
|
isNodeJS,
|
2023-06-22 22:16:25 +09:00
|
|
|
MissingPDFException,
|
|
|
|
normalizeUnicode,
|
|
|
|
OPS,
|
|
|
|
PasswordResponses,
|
|
|
|
PermissionFlag,
|
|
|
|
PromiseCapability,
|
|
|
|
shadow,
|
|
|
|
UnexpectedResponseException,
|
|
|
|
Util,
|
|
|
|
VerbosityLevel,
|
|
|
|
} from "../../src/shared/util.js";
|
|
|
|
import {
|
|
|
|
build,
|
|
|
|
getDocument,
|
|
|
|
PDFDataRangeTransport,
|
|
|
|
PDFWorker,
|
|
|
|
version,
|
|
|
|
} from "../../src/display/api.js";
|
|
|
|
import {
|
2023-09-22 01:40:35 +09:00
|
|
|
DOMSVGFactory,
|
2023-11-14 20:54:21 +09:00
|
|
|
fetchData,
|
2023-06-22 22:16:25 +09:00
|
|
|
getFilenameFromUrl,
|
|
|
|
getPdfFilenameFromUrl,
|
|
|
|
getXfaPageViewport,
|
|
|
|
isDataScheme,
|
|
|
|
isPdfFile,
|
2023-09-23 22:37:13 +09:00
|
|
|
noContextMenu,
|
2023-06-22 22:16:25 +09:00
|
|
|
PDFDateString,
|
|
|
|
PixelsPerInch,
|
|
|
|
RenderingCancelledException,
|
|
|
|
setLayerDimensions,
|
|
|
|
} from "../../src/display/display_utils.js";
|
|
|
|
import {
|
|
|
|
renderTextLayer,
|
|
|
|
updateTextLayer,
|
|
|
|
} from "../../src/display/text_layer.js";
|
|
|
|
import { AnnotationEditorLayer } from "../../src/display/editor/annotation_editor_layer.js";
|
|
|
|
import { AnnotationEditorUIManager } from "../../src/display/editor/tools.js";
|
|
|
|
import { AnnotationLayer } from "../../src/display/annotation_layer.js";
|
2023-12-01 00:21:13 +09:00
|
|
|
import { ColorPicker } from "../../src/display/editor/color_picker.js";
|
2023-11-18 02:54:26 +09:00
|
|
|
import { DrawLayer } from "../../src/display/draw_layer.js";
|
2023-06-22 22:16:25 +09:00
|
|
|
import { GlobalWorkerOptions } from "../../src/display/worker_options.js";
|
2023-11-18 02:54:26 +09:00
|
|
|
import { Outliner } from "../../src/display/editor/outliner.js";
|
2023-06-22 22:16:25 +09:00
|
|
|
import { XfaLayer } from "../../src/display/xfa_layer.js";
|
|
|
|
|
2023-09-30 18:56:27 +09:00
|
|
|
const expectedAPI = Object.freeze({
|
|
|
|
AbortException,
|
|
|
|
AnnotationEditorLayer,
|
|
|
|
AnnotationEditorParamsType,
|
|
|
|
AnnotationEditorType,
|
|
|
|
AnnotationEditorUIManager,
|
|
|
|
AnnotationLayer,
|
|
|
|
AnnotationMode,
|
|
|
|
build,
|
|
|
|
CMapCompressionType,
|
2023-12-01 00:21:13 +09:00
|
|
|
ColorPicker,
|
2023-09-30 18:56:27 +09:00
|
|
|
createValidAbsoluteUrl,
|
|
|
|
DOMSVGFactory,
|
2023-11-18 02:54:26 +09:00
|
|
|
DrawLayer,
|
2023-09-30 18:56:27 +09:00
|
|
|
FeatureTest,
|
2023-11-14 20:54:21 +09:00
|
|
|
fetchData,
|
2023-09-30 18:56:27 +09:00
|
|
|
getDocument,
|
|
|
|
getFilenameFromUrl,
|
|
|
|
getPdfFilenameFromUrl,
|
|
|
|
getXfaPageViewport,
|
|
|
|
GlobalWorkerOptions,
|
|
|
|
ImageKind,
|
|
|
|
InvalidPDFException,
|
|
|
|
isDataScheme,
|
|
|
|
isPdfFile,
|
|
|
|
MissingPDFException,
|
|
|
|
noContextMenu,
|
|
|
|
normalizeUnicode,
|
|
|
|
OPS,
|
2023-11-18 02:54:26 +09:00
|
|
|
Outliner,
|
2023-09-30 18:56:27 +09:00
|
|
|
PasswordResponses,
|
|
|
|
PDFDataRangeTransport,
|
|
|
|
PDFDateString,
|
|
|
|
PDFWorker,
|
|
|
|
PermissionFlag,
|
|
|
|
PixelsPerInch,
|
|
|
|
PromiseCapability,
|
|
|
|
RenderingCancelledException,
|
|
|
|
renderTextLayer,
|
|
|
|
setLayerDimensions,
|
|
|
|
shadow,
|
|
|
|
UnexpectedResponseException,
|
|
|
|
updateTextLayer,
|
|
|
|
Util,
|
|
|
|
VerbosityLevel,
|
|
|
|
version,
|
|
|
|
XfaLayer,
|
|
|
|
});
|
|
|
|
|
2023-06-22 22:16:25 +09:00
|
|
|
describe("pdfjs_api", function () {
|
|
|
|
it("checks that the *official* PDF.js API exposes the expected functionality", async function () {
|
|
|
|
// eslint-disable-next-line no-unsanitized/method
|
|
|
|
const pdfjsAPI = await import(
|
|
|
|
typeof PDFJSDev !== "undefined" && PDFJSDev.test("LIB")
|
|
|
|
? "../../pdf.js"
|
|
|
|
: "../../src/pdf.js"
|
|
|
|
);
|
|
|
|
|
|
|
|
// The imported Object contains an (automatically) inserted Symbol,
|
|
|
|
// hence we copy the data to allow using a simple comparison below.
|
2023-09-30 18:56:27 +09:00
|
|
|
expect({ ...pdfjsAPI }).toEqual(expectedAPI);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe("web_pdfjsLib", function () {
|
|
|
|
it("checks that the viewer re-exports the expected API functionality", async function () {
|
|
|
|
if (isNodeJS) {
|
|
|
|
pending("loadScript is not supported in Node.js.");
|
|
|
|
}
|
[api-major] Output JavaScript modules in the builds (issue 10317)
At this point in time all browsers, and also Node.js, support standard `import`/`export` statements and we can now finally consider outputting modern JavaScript modules in the builds.[1]
In order for this to work we can *only* use proper `import`/`export` statements throughout the main code-base, and (as expected) our Node.js support made this much more complicated since both the official builds and the GitHub Actions-based tests must keep working.[2]
One remaining issue is that the `pdf.scripting.js` file cannot be built as a JavaScript module, since doing so breaks PDF scripting.
Note that my initial goal was to try and split these changes into a couple of commits, however that unfortunately didn't really work since it turned out to be difficult for smaller patches to work correctly and pass (all) tests that way.[3]
This is a classic case of every change requiring a couple of other changes, with each of those changes requiring further changes in turn and the size/scope quickly increasing as a result.
One possible "issue" with these changes is that we'll now only output JavaScript modules in the builds, which could perhaps be a problem with older tools. However it unfortunately seems far too complicated/time-consuming for us to attempt to support both the old and modern module formats, hence the alternative would be to do "nothing" here and just keep our "old" builds.[4]
---
[1] The final blocker was module support in workers in Firefox, which was implemented in Firefox 114; please see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import#browser_compatibility
[2] It's probably possible to further improve/simplify especially the Node.js-specific code, but it does appear to work as-is.
[3] Having partially "broken" patches, that fail tests, as part of the commit history is *really not* a good idea in general.
[4] Outputting JavaScript modules was first requested almost five years ago, see issue 10317, and nowadays there *should* be much better support for JavaScript modules in various tools.
2023-09-28 20:00:10 +09:00
|
|
|
const apiPath = "../../build/generic/build/pdf.mjs";
|
|
|
|
await import(apiPath);
|
|
|
|
|
2023-09-30 18:56:27 +09:00
|
|
|
const webPdfjsLib = await import("../../web/pdfjs.js");
|
|
|
|
|
|
|
|
expect(Object.keys(webPdfjsLib).sort()).toEqual(
|
|
|
|
Object.keys(expectedAPI).sort()
|
|
|
|
);
|
2023-06-22 22:16:25 +09:00
|
|
|
});
|
|
|
|
});
|