Sakurai/pdf.js - pdf.js - Gitea on kemo

Sakurai/pdf.js

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

2 lines

68 B

SYSTEMD

Raw Normal View History

XFA - Add a missing method to `XFAAttribute`, to prevent breaking errors (issue 13748) *This is yet another case where I've got no idea if the patch is correct, but it does at least fix a breaking error :-)* Note how in the [`Binder._bindValue` method](https://github.com/mozilla/pdf.js/blob/683ce66a48cd54fa48e96e1925277c134859e76c/src/core/xfa/bind.js#L92-L93), we're assuming that if a `data`-value exists then it'll also be possible to actually access it. For the `XFAAttribute`-implementation however, the second method is missing and that's what causes the breaking errors in issue 13748. Please note that another possible way of "fixing" the error wouldn't been to simply change the exists-check to return `false`, and I could see that being a preferred solution. However, the reason for submitting the current patch is that we get *fewer* warnings about Nodes with mis-matched types this way.

2021-07-21 00:14:20 +09:00

https://github.com/mozilla/pdf.js/files/6849364/IFT-3R.7._v1-1E.pdf